Skip to content

Improve logic that chooses co- vs. contra-variant inferences #57909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 11 commits into from
Jun 17, 2024
Merged

Improve logic that chooses co- vs. contra-variant inferences #57909

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
80491eb
Improve logic that chooses co- vs. contra-variant inferences
Andarist Mar 22, 2024
f78cea6
rename test file
Andarist Mar 23, 2024
237aba6
ignore covariant any inferences when contravariant candidates are ava…
Andarist Mar 23, 2024
6688f3c
Merge remote-tracking branch 'origin/main' into tweak-co-contra-infer…
Andarist Mar 25, 2024
03d0eb1
Merge remote-tracking branch 'origin/main' into tweak-co-contra-infer…
Andarist May 1, 2024
810943a
Merge remote-tracking branch 'origin/main' into tweak-co-contra-infer…
Andarist May 8, 2024
b715e32
add an extra test case
Andarist May 8, 2024
2226e0b
tweak comment
Andarist Jun 14, 2024
1c3f6c9
Merge remote-tracking branch 'origin/main' into tweak-co-contra-infer…
Andarist Jun 14, 2024
169d720
update baseline
Andarist Jun 14, 2024
91d69a1
update a baseline
Andarist Jun 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update baseline
  • Loading branch information
@Andarist
Andarist committed Jun 14, 2024
commit 169d720b7e7cea509b019e1a5c309e5e8075d2f2
12 changes: 6 additions & 6 deletions tests/baselines/reference/coAndContraVariantInferences8.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,23 +20,23 @@ fn.call(null, x);
>fn.call(null, x) : void
> : ^^^^
>fn.call : <T, A extends any[], R>(this: (this: T, ...args: A) => R, thisArg: T, ...args: A) => R
> : ^ ^^ ^^^^^^^^^^^^^^^^ ^^ ^^ ^^ ^^ ^^^^^ ^^ ^^^^^^
> : ^ ^^ ^^^^^^^^^ ^^ ^^ ^^ ^^ ^^ ^^^^^ ^^ ^^^^^
>fn : (() => void) | ((a: number) => void)
> : ^^^^^^^^^^^^^^^^^ ^^ ^^^^^^^^^^
> : ^^^^^^^ ^^^^^^ ^^ ^^^^^ ^
>call : <T, A extends any[], R>(this: (this: T, ...args: A) => R, thisArg: T, ...args: A) => R
> : ^ ^^ ^^^^^^^^^^^^^^^^ ^^ ^^ ^^ ^^ ^^^^^ ^^ ^^^^^^
> : ^ ^^ ^^^^^^^^^ ^^ ^^ ^^ ^^ ^^ ^^^^^ ^^ ^^^^^
>x : number
> : ^^^^^^

fn.call(null, y);
>fn.call(null, y) : void
> : ^^^^
>fn.call : <T, A extends any[], R>(this: (this: T, ...args: A) => R, thisArg: T, ...args: A) => R
> : ^ ^^ ^^^^^^^^^^^^^^^^ ^^ ^^ ^^ ^^ ^^^^^ ^^ ^^^^^^
> : ^ ^^ ^^^^^^^^^ ^^ ^^ ^^ ^^ ^^ ^^^^^ ^^ ^^^^^
>fn : (() => void) | ((a: number) => void)
> : ^^^^^^^^^^^^^^^^^ ^^ ^^^^^^^^^^
> : ^^^^^^^ ^^^^^^ ^^ ^^^^^ ^
>call : <T, A extends any[], R>(this: (this: T, ...args: A) => R, thisArg: T, ...args: A) => R
> : ^ ^^ ^^^^^^^^^^^^^^^^ ^^ ^^ ^^ ^^ ^^^^^ ^^ ^^^^^^
> : ^ ^^ ^^^^^^^^^ ^^ ^^ ^^ ^^ ^^ ^^^^^ ^^ ^^^^^
>y : any

export {};
Expand Down