Skip to content

Uncalled function checks check negation condition #57114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexMarkUSDS wants to merge 7 commits into from
Closed

Uncalled function checks check negation condition #57114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
09cced4
Uncalled function checks check negation condition
AlexMarkUSDS Jan 20, 2024
00cc8ff
Fix format
AlexMarkUSDS Jan 21, 2024
3793795
Workaround compile issues caused by PR
AlexMarkUSDS Jan 21, 2024
bdb2698
Take a riskier approach to removing host.fileExists
AlexMarkUSDS Jan 21, 2024
a9abcb4
Remove unnecessary system.getEnvironmentVariable call
AlexMarkUSDS Jan 21, 2024
4bac889
Undo potentially compatibility-destroying changes
AlexMarkUSDS Jan 21, 2024
a5d6425
Format
AlexMarkUSDS Jan 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Undo potentially compatibility-destroying changes
  • Loading branch information
@AlexMarkUSDS
AlexMarkUSDS committed Jan 21, 2024
commit 4bac8898eb591e832dcdcfcc7c93d8665e48416e
3 changes: 3 additions & 0 deletions src/compiler/sys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,9 @@ let pollingChunkSize = createPollingIntervalBasedLevels(defaultChunkLevels);
export let unchangedPollThresholds = createPollingIntervalBasedLevels(defaultChunkLevels);

function setCustomPollingValues(system: System) {
if (system.getEnvironmentVariable === undefined) {
return;
}
const pollingIntervalChanged = setCustomLevels("TSC_WATCH_POLLINGINTERVAL", PollingInterval);
pollingChunkSize = getCustomPollingBasedLevels("TSC_WATCH_POLLINGCHUNKSIZE", defaultChunkLevels) || pollingChunkSize;
unchangedPollThresholds = getCustomPollingBasedLevels("TSC_WATCH_UNCHANGEDPOLLTHRESHOLDS", defaultChunkLevels) || unchangedPollThresholds;
Expand Down
1 change: 1 addition & 0 deletions src/services/stringCompletions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,6 +1182,7 @@ function getCompletionEntriesFromTypings(host: LanguageServiceHost, options: Com
}

function enumerateNodeModulesVisibleToScript(host: LanguageServiceHost, scriptPath: string): readonly string[] {
if (host.readFile === undefined || host.fileExists === undefined) return emptyArray;
const result: string[] = [];
for (const packageJson of findPackageJsons(scriptPath, host)) {
const contents = readJson(packageJson, host as { readFile: (filename: string) => string | undefined; }); // Cast to assert that readFile is defined
Expand Down
3 changes: 3 additions & 0 deletions src/services/utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3670,6 +3670,9 @@ export function findPackageJson(directory: string, host: LanguageServiceHost): s

/** @internal */
export function getPackageJsonsVisibleToFile(fileName: string, host: LanguageServiceHost): readonly ProjectPackageJsonInfo[] {
if (host.fileExists === undefined) {
return [];
}
const packageJsons: ProjectPackageJsonInfo[] = [];
forEachAncestorDirectory(getDirectoryPath(fileName), ancestor => {
const packageJsonFileName = combinePaths(ancestor, "package.json");
Expand Down