Skip to content

Reuse Printers with common options #52382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 17 commits into from
Jan 25, 2023
Merged

Reuse Printers with common options #52382

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
cd3afe4
Reuse Printers in symbolToStringWorker
jakebailey Jan 24, 2023
db730c9
Simplify greatly
jakebailey Jan 24, 2023
9303902
Remove reset in API
jakebailey Jan 24, 2023
8610e66
Minimize diff
jakebailey Jan 24, 2023
6d99c8f
Reuse a lot more printers
jakebailey Jan 24, 2023
4102e95
Reuse new createPrinter functions in symbolDisplay
jakebailey Jan 24, 2023
28dfb91
Use a cache with a key on subset of options
jakebailey Jan 24, 2023
2c3c9c8
Use strings
jakebailey Jan 25, 2023
bc7ad5d
Use a faster key, this one is twice as fast as the previous
jakebailey Jan 25, 2023
521a00a
Restore previous formatting
jakebailey Jan 25, 2023
82251a3
Go a little faster by comparing against undefined
jakebailey Jan 25, 2023
ce0f7ce
Revert "Go a little faster by comparing against undefined"
jakebailey Jan 25, 2023
8f26dc1
Revert "Restore previous formatting"
jakebailey Jan 25, 2023
efe881c
Revert "Use a faster key, this one is twice as fast as the previous"
jakebailey Jan 25, 2023
70076ea
Revert "Use strings"
jakebailey Jan 25, 2023
4d7ab40
Revert "Use a cache with a key on subset of options"
jakebailey Jan 25, 2023
708216a
Merge branch 'main' into pooled-printers
jakebailey Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Restore previous formatting" 
This reverts commit 521a00a.
  • Loading branch information
@jakebailey
jakebailey committed Jan 25, 2023
commit 8f26dc1b2c07cdfc866bfc54626fca8281e483fd
4 changes: 3 additions & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6123,7 +6123,9 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
function symbolToStringWorker(writer: EmitTextWriter) {
const entity = builder(symbol, meaning!, enclosingDeclaration, nodeFlags)!; // TODO: GH#18217
// add neverAsciiEscape for GH#39027
const printer = enclosingDeclaration?.kind === SyntaxKind.SourceFile ? createOrReusePrinter({ removeComments: true, neverAsciiEscape: true }) : createOrReusePrinter({ removeComments: true });
const printer = enclosingDeclaration?.kind === SyntaxKind.SourceFile
? createOrReusePrinter({ removeComments: true, neverAsciiEscape: true })
: createOrReusePrinter({ removeComments: true });
const sourceFile = enclosingDeclaration && getSourceFileOfNode(enclosingDeclaration);
printer.writeNode(EmitHint.Unspecified, entity, /*sourceFile*/ sourceFile, writer);
Comment thread
jakebailey marked this conversation as resolved.
Outdated
return writer;
Expand Down