Skip to content

Fix(47969): String.prototypr.replace docs fix #50041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
navya9singh merged 10 commits into from
Sep 28, 2022
Merged

Fix(47969): String.prototypr.replace docs fix #50041

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3cade4c
String.prototype.replace docs fix.
navya9singh Jul 25, 2022
04df1e1
Follow up changes to es5.d.ts
navya9singh Jul 25, 2022
34c3b9c
Fixed changes to previous commit:
navya9singh Jul 25, 2022
472584f
Changes to resolve pr comments
navya9singh Jul 27, 2022
29e50b3
Rewording documentation
navya9singh Sep 16, 2022
0507192
Accepting baselines
navya9singh Sep 16, 2022
906510e
Fixes for pr
navya9singh Sep 16, 2022
305f4bd
Merge branch 'main' into fix/47969
navya9singh Sep 20, 2022
abc58bd
Fixing baseline errors
navya9singh Sep 20, 2022
8e71f42
Fixing pr comments
navya9singh Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rewording documentation
  • Loading branch information
@navya9singh
navya9singh committed Sep 16, 2022
commit 29e50b314900d22b08f6472918f59ae2b40aba08
2 changes: 1 addition & 1 deletion src/lib/es2015.symbol.wellknown.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ interface String {
match(matcher: { [Symbol.match](string: string): RegExpMatchArray | null; }): RegExpMatchArray | null;

/**
* Passes a string and {@linkcode replaceValue} to the [Symbol.replace] method on {@linkcode searchValue}. This method is expected to implement its own replacement algorithm.
* Passes a string and {@linkcode replaceValue} to the `[Symbol.replace]` method on {@linkcode searchValue}. This method is expected to implement its own replacement algorithm.
* @param searchValue An object that supports searching for and replacing matches within a string.
* @param replaceValue The replacement text.
*/
Expand Down
2 changes: 1 addition & 1 deletion src/lib/es5.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ interface String {
/**
* Replaces text in a string, using a regular expression or search string.
* @param searchValue A string or regular expression to search for.
* @param replaceValue A string containing the text to replace. When the {@linkcode searchValue} is a string, only the first match is replaced. If the {@linkcode searchValue} is a RegExp, all matches are replaced if the g flag is set. Otherwise only the first one is.
* @param replaceValue A string containing the text to replace. When the {@linkcode searchValue} is a RegExp, all matches are replaced if the g flag is set (taking into account the y flag if present). Otherwise {@linkcode searchValue} only the first match is replaced.
Comment thread
navya9singh marked this conversation as resolved.
Outdated
*/
replace(searchValue: string | RegExp, replaceValue: string): string;

Expand Down