Skip to content

Fix(47969): String.prototypr.replace docs fix #50041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
navya9singh merged 10 commits into from
Sep 28, 2022
Merged

Fix(47969): String.prototypr.replace docs fix #50041

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3cade4c
String.prototype.replace docs fix.
navya9singh Jul 25, 2022
04df1e1
Follow up changes to es5.d.ts
navya9singh Jul 25, 2022
34c3b9c
Fixed changes to previous commit:
navya9singh Jul 25, 2022
472584f
Changes to resolve pr comments
navya9singh Jul 27, 2022
29e50b3
Rewording documentation
navya9singh Sep 16, 2022
0507192
Accepting baselines
navya9singh Sep 16, 2022
906510e
Fixes for pr
navya9singh Sep 16, 2022
305f4bd
Merge branch 'main' into fix/47969
navya9singh Sep 20, 2022
abc58bd
Fixing baseline errors
navya9singh Sep 20, 2022
8e71f42
Fixing pr comments
navya9singh Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Follow up changes to es5.d.ts
  • Loading branch information
@navya9singh
navya9singh committed Jul 25, 2022
commit 04df1e18d9161035a18e0ea44eec8d1ce7d4f39d
2 changes: 1 addition & 1 deletion src/lib/es5.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ interface String {
/**
* Replaces text in a string, using a regular expression or search string.
* @param searchValue A string to search for.
Comment thread
navya9singh marked this conversation as resolved.
Outdated
* @param replaceValue A string containing the text to replace for every successful match of searchValue in this string.
* @param replaceValue A string containing the text to replace. When the searchvalue is a string, only the first match is replaced. If the searchValue is a Regexp, all matches are replaced if the g flag is set. Otherwise only the first one is.
Comment thread
navya9singh marked this conversation as resolved.
Outdated

@Josh-Cena Josh-Cena Jul 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an "interesting" aspect where "aaa-a".replace(/a/gy, "x") is xxx-a. I don't know how detailed we want it to be, but "all matches are replaced if the g flag is set" is technically not correct—and arguably less correct than before.

@sandersn sandersn Jul 27, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MDN's documentation for the sticky flag says that it ignores the global flag. If that's true, then I think it's fine to document it as-is, since you'll presumably find out about y long after g and hopefully read about the override.

However, is that consistent with your example? If there's some kind of interaction, it might be worth documenting.

@Josh-Cena Josh-Cena Jul 28, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an open issue for it: mdn/content#1454 I just haven't gotten around to fix it.

*/
replace(searchValue: string | RegExp, replaceValue: string): string;

Expand Down