Skip to content

Support go-to-definition for imports of arbitrary files #42539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewbranch merged 10 commits into from
Mar 1, 2021
Merged

Support go-to-definition for imports of arbitrary files #42539

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5a039af
Support go-to-definition for imports of scripts and arbitrary files
andrewbranch Jan 28, 2021
8a9cc94
Support go-to-definition for non-existent files
andrewbranch Jan 28, 2021
5f256f1
Add missing file property
andrewbranch Jan 28, 2021
248ed37
Use `isExternalModuleNameRelative` instead of `!pathIsBareSpecifier`
andrewbranch Jan 29, 2021
f6d3b18
Add partial semantic test
andrewbranch Feb 1, 2021
a5195f5
Combine with symbol search for non-source-file file references
andrewbranch Feb 16, 2021
54d8a72
Fix and accept API baselines
andrewbranch Feb 16, 2021
48e0d26
Fix useless or
andrewbranch Feb 16, 2021
c2aa82c
A definition is unverified if the file path was a guess, even if a so…
andrewbranch Feb 26, 2021
280926f
Merge branch 'master' into bug/41861
andrewbranch Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use isExternalModuleNameRelative instead of !pathIsBareSpecifier
  • Loading branch information
@andrewbranch
andrewbranch authored Jan 29, 2021
commit 248ed3728e7a4a035e91bc5ec67c4fcc50df5326
2 changes: 1 addition & 1 deletion src/services/goToDefinition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ namespace ts.GoToDefinition {

if (sourceFile.resolvedModules?.size) {
const node = getTokenAtPosition(sourceFile, position);
if (isModuleSpecifierLike(node) && !pathIsBareSpecifier(node.text) && sourceFile.resolvedModules.has(node.text)) {
if (isModuleSpecifierLike(node) && isExternalModuleNameRelative(node.text) && sourceFile.resolvedModules.has(node.text)) {
const fileName = sourceFile.resolvedModules.get(node.text)?.resolvedFileName
Comment thread
andrewbranch marked this conversation as resolved.
Outdated
|| resolvePath(getDirectoryPath(sourceFile.fileName), node.text);
Comment thread
andrewbranch marked this conversation as resolved.
Outdated
return {
Expand Down