Skip to content

Include all properties from the mapped modifier type when calculating… #41976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weswigham merged 2 commits into from
Jan 27, 2021
Merged

Include all properties from the mapped modifier type when calculating… #41976

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
597a9c6
Include all properties from the mapped modifier type when calculating…
weswigham Dec 15, 2020
335a4e3
Merge branch 'master' into include-modifier-index-props
weswigham Jan 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'master' into include-modifier-index-props
  • Loading branch information
@weswigham
weswigham committed Jan 27, 2021
commit 335a4e39372d7885d3d1337f3badfa5903c7df70
2 changes: 1 addition & 1 deletion tests/baselines/reference/computedTypesKeyofNoIndexSignatureType.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ type WithoutIndex = OmitIndex<WithIndex, string>; // { foo: "hello"; bar: "world
>WithoutIndex : OmitIndex<{ [x: string]: {}; foo: "hello"; bar: "world"; }, string>

type FooBarKey = keyof FooBar; // "foo" | "bar" <-- OK
>FooBarKey : "foo" | "bar"
>FooBarKey : keyof FooBar

type WithIndexKey = keyof WithIndex; // string | number <-- Expected: string
>WithIndexKey : string | number
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.