Skip to content

Allow calls on unions of dissimilar signatures #29011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weswigham merged 13 commits into from
Dec 20, 2018
Merged

Allow calls on unions of dissimilar signatures #29011

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8184037
Add core of new union signature logic and test - needs intersection s…
weswigham Dec 13, 2018
6c2e1e1
Add inversion of variance for class props lookup from union sig returns
weswigham Dec 13, 2018
8ea94cd
Fix lints
weswigham Dec 13, 2018
407054a
Combine parameter names for nicer quick info
weswigham Dec 15, 2018
d7c668a
PR feedback 1
weswigham Dec 19, 2018
5df3c69
Merge branch 'master' into dissimilar-union-signatures
weswigham Dec 19, 2018
f24c7f5
Fix miscopy
weswigham Dec 19, 2018
d28d87f
PR feedback round 2
weswigham Dec 19, 2018
f1d78e9
Remove argument name combining because loc :(
weswigham Dec 19, 2018
9c7abc4
Nit cleanup round 3
weswigham Dec 19, 2018
2ef6733
Reinline getTupleTypeForArgumentAtPos
weswigham Dec 19, 2018
875bb0e
Remove a tad more
weswigham Dec 20, 2018
7b2ad7f
No step on sneky off-by-one error
weswigham Dec 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix miscopy
  • Loading branch information
@weswigham
weswigham committed Dec 19, 2018
commit f24c7f555a955e382d75a27242a44dab93d7d0fe
2 changes: 1 addition & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6839,7 +6839,7 @@ namespace ts {
if (signatures === masterList) continue;
const signature = signatures[0];
Debug.assert(!!signature, "getUnionSignatures bails early on empty signature lists and should not have empty lists on second pass");
results = signature.typeParameters && some(results, s => !!s.typeParameters) ? undefined : map(results, sig => combineSignaturesOfUnionMembers(sig, addition));
results = signature.typeParameters && some(results, s => !!s.typeParameters) ? undefined : map(results, sig => combineSignaturesOfUnionMembers(sig, signature));
if (!results) {
break;
}
Expand Down