Skip to content

Strict bind, call, and apply methods on functions #27028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahejlsberg merged 21 commits into from
Sep 25, 2018
+1,281 −82
Merged

Strict bind, call, and apply methods on functions #27028

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
46bd405
Better scheme for choosing between co- and contra-variant inferences
ahejlsberg Sep 10, 2018
df83784
Accept new baselines
ahejlsberg Sep 10, 2018
22a384d
New --strictBindCallApply flag in compiler
ahejlsberg Sep 10, 2018
55b6513
New CallableFunction and NewableFunction types in es5.d.ts
ahejlsberg Sep 10, 2018
a85b896
Accept new baselines
ahejlsberg Sep 10, 2018
b687d90
Add CallableFunction/NewableFunction to virtual file system
ahejlsberg Sep 10, 2018
1e3625c
Accept new baselines
ahejlsberg Sep 10, 2018
a5dece3
Update declarations
ahejlsberg Sep 11, 2018
d069da2
Update getAugmentedPropertiesOfType
ahejlsberg Sep 11, 2018
e9679f0
Add tests
ahejlsberg Sep 11, 2018
8a41f5f
Accept new baselines
ahejlsberg Sep 11, 2018
91123fc
Minor fix
ahejlsberg Sep 11, 2018
b67a261
Merge branch 'master' into typedBindCallApply
ahejlsberg Sep 11, 2018
0226b66
Accept new baselines
ahejlsberg Sep 11, 2018
52293ed
Fix inference when source and target both have rest parameters
ahejlsberg Sep 12, 2018
2e17deb
Prefer error candidates with no rest parameters over those with
ahejlsberg Sep 12, 2018
df1e33a
Add 'bind' overloads for rest parameter arrays
ahejlsberg Sep 12, 2018
339f310
Accept new baselines
ahejlsberg Sep 12, 2018
9414fbe
Merge branch 'master' into typedBindCallApply
ahejlsberg Sep 12, 2018
5510e07
Merge branch 'master' into typedBindCallApply
ahejlsberg Sep 24, 2018
b6e66c2
Accept new baselines
ahejlsberg Sep 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update getAugmentedPropertiesOfType
  • Loading branch information
@ahejlsberg
ahejlsberg committed Sep 11, 2018
commit d069da2f66334a4ea65d5ed30831ee46dbde1817
7 changes: 5 additions & 2 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27758,8 +27758,11 @@ namespace ts {
function getAugmentedPropertiesOfType(type: Type): Symbol[] {
type = getApparentType(type);
const propsByName = createSymbolTable(getPropertiesOfType(type));
if (typeHasCallOrConstructSignatures(type)) {
forEach(getPropertiesOfType(globalFunctionType), p => {
const functionType = getSignaturesOfType(type, SignatureKind.Call).length ? globalCallableFunctionType :
getSignaturesOfType(type, SignatureKind.Call).length ? globalNewableFunctionType :
undefined;
if (functionType) {
forEach(getPropertiesOfType(functionType), p => {
if (!propsByName.has(p.escapedName)) {
propsByName.set(p.escapedName, p);
}
Expand Down