Skip to content

Distribute indexed accesses when simplifying them #26281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weswigham merged 14 commits into from
Aug 27, 2018
Merged

Distribute indexed accesses when simplifying them #26281

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1ff6007
unknownify accesses
weswigham Aug 7, 2018
87613bc
Move to simplify to break less with fewer changes
weswigham Aug 7, 2018
c881d97
Accept baselines for now
weswigham Aug 7, 2018
518046c
Always propegate any as an index type
weswigham Aug 8, 2018
17d37ec
Fix flow control in the presence of simplifiable types
weswigham Aug 8, 2018
89b9e6e
Add spy repro from #25181
weswigham Aug 8, 2018
02bd1a1
Merge branch 'master' into unknownify-accesses
weswigham Aug 20, 2018
5bf01b3
Retain errorType when it is used as a marker for the lack of a constr…
weswigham Aug 20, 2018
c68d37a
Small refinement
weswigham Aug 20, 2018
bbb1164
Merge branch 'master' into unknownify-accesses
weswigham Aug 22, 2018
82b8a4f
Add new test
weswigham Aug 22, 2018
98e9b3e
Move most potentially recursive types from isIdenticalTo into structu…
weswigham Aug 23, 2018
22b9a16
Fix nits
weswigham Aug 27, 2018
37e5f6d
Doesnt need to be undefineable at all
weswigham Aug 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Doesnt need to be undefineable at all
  • Loading branch information
@weswigham
weswigham committed Aug 27, 2018
commit 37e5f6de44e0b2f4e716a57847af5399c1606779
8 changes: 4 additions & 4 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15140,14 +15140,14 @@ namespace ts {
return type.flags & TypeFlags.InstantiableNonPrimitive && maybeTypeOfKind(getBaseConstraintOfType(type) || emptyObjectType, TypeFlags.Nullable);
}

function getConstraintForLocation(type: Type, node: Node | undefined): Type;
function getConstraintForLocation(type: Type | undefined, node: Node | undefined): Type | undefined;
function getConstraintForLocation(type: Type, node: Node | undefined): Type | undefined {
function getConstraintForLocation(type: Type, node: Node): Type;
function getConstraintForLocation(type: Type | undefined, node: Node): Type | undefined;
function getConstraintForLocation(type: Type, node: Node): Type | undefined {
// When a node is the left hand expression of a property access, element access, or call expression,

@ahejlsberg ahejlsberg Aug 27, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be node: Node | undefined, i.e. not an optional parameter? It seems pointless to make it optional since the function will never do anything if you don't pass an argument for it.

Also, when might node be undefined? Not clear to me what those changes are accomplishing.

@weswigham weswigham Aug 27, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't need to be undefine'd-able at all. I probably factored the place where it may have been undefinable so it wouldn't be while I was working on it - fix't.

// and the type of the node includes type variables with constraints that are nullable, we fetch the
// apparent type of the node *before* performing control flow analysis such that narrowings apply to
// the constraint type.
if (node && type && isConstraintPosition(node) && forEachType(type, typeHasNullableConstraint)) {
if (type && isConstraintPosition(node) && forEachType(type, typeHasNullableConstraint)) {
return mapType(getWidenedType(type), getBaseConstraintOrType);
}
return type;
Expand Down