Skip to content

Attempt at implementing propagated inference for free type parameters (#9366) #24626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kpdonn wants to merge 4 commits into from
Closed

Attempt at implementing propagated inference for free type parameters (#9366) #24626

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4a07ae
Add some tests for existing behavior inferring from generic functions.
kpdonn Jun 2, 2018
664c4d9
Changes to allow propagating type parameters with no inferences.
kpdonn Jun 2, 2018
2e51a07
Update baselines.
kpdonn Jun 2, 2018
ccb5dd4
Forgot that I had disabled building with local compiler.
kpdonn Jun 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Forgot that I had disabled building with local compiler.
  • Loading branch information
@kpdonn
kpdonn committed Jun 2, 2018
commit ccb5dd4ab6abd3369b603c8d50aa24c2929c76ae
4 changes: 2 additions & 2 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19681,7 +19681,7 @@ namespace ts {
const parameter = signature.parameters[i];
if (!getEffectiveTypeAnnotationNode(<ParameterDeclaration>parameter.valueDeclaration)) {
const contextualParameterType = getTypeAtPosition(context, i);
const originalContextualParameterType = signature.isContextuallyTyped ? getTypeAtPosition(context.target!, i) : undefined;
const originalContextualParameterType = signature.isContextuallyTyped && context.target ? getTypeAtPosition(context.target, i) : undefined;
assignTypeToParameterAndFixTypeParameters(parameter, contextualParameterType, contextualParameterType === originalContextualParameterType);
for (const tp of getFreeTypeParameters(contextualParameterType)) {
node.contextualTypeParameters = appendIfUnique(node.contextualTypeParameters, tp);
Expand All @@ -19693,7 +19693,7 @@ namespace ts {
const parameter = last(signature.parameters);
if (isTransientSymbol(parameter) || !getEffectiveTypeAnnotationNode(<ParameterDeclaration>parameter.valueDeclaration)) {
const contextualParameterType = getTypeOfSymbol(last(context.parameters));
const originalContextualParameterType = signature.isContextuallyTyped ? getTypeOfSymbol(last(context.target!.parameters)) : undefined;
const originalContextualParameterType = signature.isContextuallyTyped && context.target ? getTypeOfSymbol(last(context.target.parameters)) : undefined;
assignTypeToParameterAndFixTypeParameters(parameter, contextualParameterType, contextualParameterType === originalContextualParameterType);
for (const tp of getFreeTypeParameters(contextualParameterType)) {
node.contextualTypeParameters = appendIfUnique(node.contextualTypeParameters, tp);
Expand Down