Skip to content

Support a "getCombinedCodeFix" service #20338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
15 commits merged into from
Dec 7, 2017
Merged

Support a "getCombinedCodeFix" service #20338

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5c70641
Support a "getCombinedCodeFix" service
Nov 13, 2017
be19542
Rename things
Nov 30, 2017
8a1865f
Code review
Nov 30, 2017
b89b7fe
Merge branch 'master' into codeFixAll
Nov 30, 2017
a8b3afc
Rename things
Dec 1, 2017
a38216c
Update API baselines
Dec 1, 2017
c621e3f
CodeActionAll -> CombinedCodeActions
Dec 1, 2017
d0af16a
Merge branch 'master' into codeFixAll
Dec 5, 2017
2db8649
Take a `scope` parameter instead of `fileName` for flexibility
Dec 5, 2017
f2031be
Renames and bugfixes
Dec 5, 2017
79c0150
Merge branch 'master' into codeFixAll
Dec 6, 2017
8a61761
Make API changes internal
Dec 7, 2017
41c5710
Merge branch 'master' into codeFixAll
Dec 7, 2017
87d30c0
Code review
Dec 7, 2017
5f7ba73
Update comment
Dec 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update API baselines
  • Loading branch information
Andy Hanson committed Dec 1, 2017
commit a38216c3c4d5cc1d1f5dff1ffef1edd9bd7b2518
2 changes: 1 addition & 1 deletion src/services/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ namespace ts {

export interface CodeFix extends CodeAction {
/** If present, one may call 'getCombinedCodeFix' with this actionId. */
actionId?: {} | undefined;
actionId?: {};
}

export interface CodeActionAll {
Expand Down
8 changes: 4 additions & 4 deletions tests/baselines/reference/api/tsserverlibrary.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4075,8 +4075,8 @@ declare namespace ts {
commands?: CodeActionCommand[];
}
interface CodeFix extends CodeAction {
/** If present, one may call 'applyAllCodeFixesInGroup' with this actionId. */
actionId: {} | undefined;
/** If present, one may call 'getCombinedCodeFix' with this actionId. */
actionId?: {};
}
interface CodeActionAll {
changes: FileTextChanges[];
Expand Down Expand Up @@ -5275,7 +5275,7 @@ declare namespace ts.server.protocol {
arguments: GetCombinedCodeFixRequestArgs;
}
interface GetCombinedCodeFixResponse extends Response {
body: CodeActionAll;
body: CombinedCodeActions;
}
interface ApplyCodeActionCommandRequest extends Request {
command: CommandTypes.ApplyCodeActionCommand;
Expand Down Expand Up @@ -6065,7 +6065,7 @@ declare namespace ts.server.protocol {
/** A command is an opaque object that should be passed to `ApplyCodeActionCommandRequestArgs` without modification. */
commands?: {}[];
}
interface CodeActionAll {
interface CombinedCodeActions {
changes: FileCodeEdits[];
commands?: {}[];
}
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/api/typescript.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4076,7 +4076,7 @@ declare namespace ts {
}
interface CodeFix extends CodeAction {
/** If present, one may call 'getCombinedCodeFix' with this actionId. */
actionId: {} | undefined;
actionId?: {};
}
interface CodeActionAll {
changes: FileTextChanges[];
Expand Down