Skip to content

noUnusedLocals: Warn for recursive call to private method #18920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Oct 17, 2017
Merged

noUnusedLocals: Warn for recursive call to private method #18920

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4123ac
noUnusedLocals: Warn for recursive call to private method
Oct 3, 2017
89dd2d8
Merge branch 'master' into noUnusedLocals_privateMethod
Oct 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'master' into noUnusedLocals_privateMethod
  • Loading branch information
Andy Hanson committed Oct 17, 2017
commit 89dd2d8bfd9a9efa978981e56a84973a6eada366
9 changes: 5 additions & 4 deletions tests/baselines/reference/noUnusedLocals_selfReference.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
tests/cases/compiler/noUnusedLocals_selfReference.ts(3,10): error TS6133: 'f' is declared but its value is never read.
tests/cases/compiler/noUnusedLocals_selfReference.ts(4,7): error TS6133: 'C' is declared but its value is never read.
tests/cases/compiler/noUnusedLocals_selfReference.ts(7,6): error TS6133: 'E' is declared but its value is never read.
tests/cases/compiler/noUnusedLocals_selfReference.ts(9,19): error TS6133: 'm' is declared but its value is never read.
tests/cases/compiler/noUnusedLocals_selfReference.ts(5,14): error TS6133: 'g' is declared but its value is never read.
tests/cases/compiler/noUnusedLocals_selfReference.ts(9,7): error TS6133: 'C' is declared but its value is never read.
tests/cases/compiler/noUnusedLocals_selfReference.ts(12,6): error TS6133: 'E' is declared but its value is never read.
tests/cases/compiler/noUnusedLocals_selfReference.ts(14,19): error TS6133: 'm' is declared but its value is never read.


==== tests/cases/compiler/noUnusedLocals_selfReference.ts (4 errors) ====
==== tests/cases/compiler/noUnusedLocals_selfReference.ts (5 errors) ====
export {}; // Make this a module scope, so these are local variables.

function f() {
Expand Down
22 changes: 11 additions & 11 deletions tests/baselines/reference/noUnusedLocals_selfReference.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,22 +30,22 @@ enum E { A = 0, B = E.A }
>A : Symbol(E.A, Decl(noUnusedLocals_selfReference.ts, 11, 8))

class P { private m() { this.m; } }
>P : Symbol(P, Decl(noUnusedLocals_selfReference.ts, 6, 25))
>m : Symbol(P.m, Decl(noUnusedLocals_selfReference.ts, 8, 9))
>this.m : Symbol(P.m, Decl(noUnusedLocals_selfReference.ts, 8, 9))
>this : Symbol(P, Decl(noUnusedLocals_selfReference.ts, 6, 25))
>m : Symbol(P.m, Decl(noUnusedLocals_selfReference.ts, 8, 9))
>P : Symbol(P, Decl(noUnusedLocals_selfReference.ts, 11, 25))
>m : Symbol(P.m, Decl(noUnusedLocals_selfReference.ts, 13, 9))
>this.m : Symbol(P.m, Decl(noUnusedLocals_selfReference.ts, 13, 9))
>this : Symbol(P, Decl(noUnusedLocals_selfReference.ts, 11, 25))
>m : Symbol(P.m, Decl(noUnusedLocals_selfReference.ts, 13, 9))

P;
>P : Symbol(P, Decl(noUnusedLocals_selfReference.ts, 6, 25))
>P : Symbol(P, Decl(noUnusedLocals_selfReference.ts, 11, 25))

// Does not detect mutual recursion.
function g() { D; }
>g : Symbol(g, Decl(noUnusedLocals_selfReference.ts, 9, 2))
>D : Symbol(D, Decl(noUnusedLocals_selfReference.ts, 12, 19))
>g : Symbol(g, Decl(noUnusedLocals_selfReference.ts, 14, 2))
>D : Symbol(D, Decl(noUnusedLocals_selfReference.ts, 17, 19))

class D { m() { g; } }
>D : Symbol(D, Decl(noUnusedLocals_selfReference.ts, 12, 19))
>m : Symbol(D.m, Decl(noUnusedLocals_selfReference.ts, 13, 9))
>g : Symbol(g, Decl(noUnusedLocals_selfReference.ts, 9, 2))
>D : Symbol(D, Decl(noUnusedLocals_selfReference.ts, 17, 19))
>m : Symbol(D.m, Decl(noUnusedLocals_selfReference.ts, 18, 9))
>g : Symbol(g, Decl(noUnusedLocals_selfReference.ts, 14, 2))

You are viewing a condensed version of this merge commit. You can view the full changes here.