Fix get_tightbbox to include axis labels in 3D axes#31573
Open
Sathush504 wants to merge 2 commits into
Open
Conversation
savefig(bbox_inches='tight') was clipping zlabel and xlabel on 3D axes because Axes3D.get_tightbbox() did not include axis label bounding boxes in its calculation. On 2D axes the superclass handles this correctly. Fixes matplotlib#31568 Related to matplotlib#28117
Contributor
|
You should run the linter and recommit. |
Author
Fixed. ruff reported two issues (missing blank line and no newline at end of file), both resolved and pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
savefig(bbox_inches='tight') was clipping zlabel and xlabel on 3D axes because Axes3D.get_tightbbox() did not include axis label bounding boxes in its calculation. On 2D axes the superclass handles this correctly.
Fixes #31568
Related to #28117
PR summary
AI Disclosure
PR checklist