Reverts macosx change to ARC#23654
Merged
Merged
Conversation
greglucas
added
Release critical
tacaswell
approved these changes
Aug 18, 2022
jklymak
approved these changes
Aug 18, 2022
Member
|
.... have I mentioned I really really dislike the subplot tool...I don't think we should have ever allowed a modal dialog on the current open figure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Reverting the ARC PR to avoid the segfault from the subplot_tool for now.
xref: #23653
Revert "MNT: Change objective C code to Automatic Reference Counting (ARC)"
This reverts commit b46ab89.
Revert "FIX: remove one more autorelease"
This reverts commit ec0a325.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).