Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

fix cli import in watcher#13750

Merged
alexrashed merged 1 commit into
mainfrom
fix-cli-imports-2
Feb 12, 2026
Merged

fix cli import in watcher#13750
alexrashed merged 1 commit into
mainfrom
fix-cli-imports-2

Conversation

@alexrashed
Copy link
Copy Markdown
Member

@alexrashed alexrashed commented Feb 12, 2026 •
edited
Loading

Motivation

With #13704, the CLI code was removed from this repo.
However, due to the timing of the merges, one import of the CLI introduced in #13718 was not updated in the PR.
This causes the new watcher to fail:

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/Users/nikosmichas/PycharmProjects/localstack/localstack-core/localstack/dev/run/__main__.py", line 19, in <module>
    from localstack.dev.run.watcher import collect_watch_directories, start_file_watcher
  File "/Users/nikosmichas/PycharmProjects/localstack/localstack-core/localstack/dev/run/watcher.py", line 11, in <module>
    from localstack.cli import console
ImportError: cannot import name 'console' from 'localstack.cli' (/.../localstack/cli/__init__.py)

This PR fixes this import.

Changes

  • Update the console import to fix the watcher script.

@alexrashed alexrashed added semver: patch Non-breaking changes which can be included in patch releases review: merge when ready Signals to the reviewer that a PR can be merged if accepted docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Feb 12, 2026
@alexrashed alexrashed added this to the 4.14 milestone Feb 12, 2026
bentsku
bentsku approved these changes Feb 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing it 🙏

@alexrashed alexrashed marked this pull request as ready for review February 12, 2026 11:42
@alexrashed alexrashed merged commit 9b4b550 into main Feb 12, 2026
24 of 27 checks passed
@alexrashed alexrashed deleted the fix-cli-imports-2 branch February 12, 2026 11:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@simonrw simonrw Awaiting requested review from simonrw

@silv-io silv-io Awaiting requested review from silv-io

1 more reviewer

@bentsku bentsku bentsku approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.14

Development

Successfully merging this pull request may close these issues.

2 participants

@alexrashed @bentsku