This repository was archived by the owner on Mar 23, 2026. It is now read-only.
SecretsManager: add tag/untag resource handling for deleted secrets#13662
Merged
macnev2013 merged 1 commit intoFeb 5, 2026
Conversation
Contributor
Author
|
Hi @ryan-berke @macnev2013 attempted a fix for the issue #13648 let me know if any changes required! |
macnev2013
reviewed
Feb 2, 2026
Contributor
macnev2013
left a comment
macnev2013
left a comment
There was a problem hiding this comment.
Thanks for the contribution! 🚀
Before we can proceed, could you please sign the CLA? You can do so by posting the following comment on this PR:
I have read the CLA Document and I hereby sign the CLA
macnev2013
added
semver: patch
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
btw, I already did it on one of my previous PR(#13554) |
Member
|
Hey @shubhiscoding! Thanks for your contribution! |
macnev2013
approved these changes
Feb 5, 2026
Contributor
macnev2013
left a comment
macnev2013
left a comment
There was a problem hiding this comment.
Thanks for the contribution! LGTM 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #13648
LocalStack incorrectly allows tagging and untagging operations on secrets that have been marked for deletion. AWS Secrets Manager rejects these operations with an
InvalidRequestException.Changes
@patchforSecretsManagerBackend.tag_resourceto check if the secret is marked for deletion before allowing tagging@patchforSecretsManagerBackend.untag_resourceto check if the secret is marked for deletion before allowing untaggingInvalidRequestExceptionwith the same error message as AWSTests
test_tag_untag_resource_on_deleted_secret- an AWS-validated snapshot test that verifies bothtag_resourceanduntag_resourceoperations fail withInvalidRequestExceptionwhen the secret is marked for deletionRelated