also fix connectionId for UpdateIntegration

bentsku · bentsku · commit a494e5374fb9 · 2025-10-08T11:07:31.000+02:00
diff --git a/localstack-core/localstack/services/apigateway/legacy/provider.py b/localstack-core/localstack/services/apigateway/legacy/provider.py
@@ -2158,6 +2158,7 @@ def update_integration(
             raise NotFoundException("Invalid Integration identifier specified")
 
         integration = method.method_integration
+        # TODO: validate the patch operations
         patch_api_gateway_entity(integration, patch_operations)
 
         # fix data types
@@ -2166,8 +2167,12 @@ def update_integration(
         if skip_verification := (integration.tls_config or {}).get("insecureSkipVerification"):
             integration.tls_config["insecureSkipVerification"] = str_to_bool(skip_verification)
 
-        integration_dict: Integration = integration.to_json()
-        return integration_dict
+        response: Integration = integration.to_json()
+
+        if connection_id := getattr(integration, "connection_id", None):
+            response["connectionId"] = connection_id
+
+        return response
 
     def delete_integration(
         self,
diff --git a/tests/aws/services/apigateway/test_apigateway_api.py b/tests/aws/services/apigateway/test_apigateway_api.py
@@ -4137,3 +4137,24 @@ def test_create_integration_with_vpc_link(
             httpMethod="GET",
         )
         snapshot.match("get-integration-vpc-link", get_integration)
+
+        update_integration = aws_client.apigateway.update_integration(
+            restApiId=rest_api_id,
+            resourceId=root_resource_id,
+            httpMethod="GET",
+            patchOperations=[
+                {
+                    "op": "replace",
+                    "path": "/connectionId",
+                    "value": "${stageVariables.vpcLinkIdBeta}",
+                }
+            ],
+        )
+        snapshot.match("update-integration-vpc-link", update_integration)
+
+        get_integration_update = aws_client.apigateway.get_integration(
+            restApiId=rest_api_id,
+            resourceId=root_resource_id,
+            httpMethod="GET",
+        )
+        snapshot.match("get-integration-update-vpc-link", get_integration_update)
diff --git a/tests/aws/services/apigateway/test_apigateway_api.snapshot.json b/tests/aws/services/apigateway/test_apigateway_api.snapshot.json
@@ -4910,7 +4910,7 @@
     }
   },
   "tests/aws/services/apigateway/test_apigateway_api.py::TestApigatewayIntegration::test_create_integration_with_vpc_link": {
-    "recorded-date": "06-10-2025, 18:07:40",
+    "recorded-date": "08-10-2025, 09:05:56",
     "recorded-content": {
       "put-integration-vpc-link": {
         "cacheKeyParameters": [],
@@ -4941,6 +4941,36 @@
           "HTTPHeaders": {},
           "HTTPStatusCode": 200
         }
+      },
+      "update-integration-vpc-link": {
+        "cacheKeyParameters": [],
+        "cacheNamespace": "<cache-namespace:1>",
+        "connectionId": "${stageVariables.vpcLinkIdBeta}",
+        "connectionType": "VPC_LINK",
+        "httpMethod": "GET",
+        "passthroughBehavior": "WHEN_NO_MATCH",
+        "timeoutInMillis": 29000,
+        "type": "HTTP_PROXY",
+        "uri": "http://my-vpclink-test-nlb-1234567890abcdef.<region>.amazonaws.com",
+        "ResponseMetadata": {
+          "HTTPHeaders": {},
+          "HTTPStatusCode": 200
+        }
+      },
+      "get-integration-update-vpc-link": {
+        "cacheKeyParameters": [],
+        "cacheNamespace": "<cache-namespace:1>",
+        "connectionId": "${stageVariables.vpcLinkIdBeta}",
+        "connectionType": "VPC_LINK",
+        "httpMethod": "GET",
+        "passthroughBehavior": "WHEN_NO_MATCH",
+        "timeoutInMillis": 29000,
+        "type": "HTTP_PROXY",
+        "uri": "http://my-vpclink-test-nlb-1234567890abcdef.<region>.amazonaws.com",
+        "ResponseMetadata": {
+          "HTTPHeaders": {},
+          "HTTPStatusCode": 200
+        }
       }
     }
   }
diff --git a/tests/aws/services/apigateway/test_apigateway_api.validation.json b/tests/aws/services/apigateway/test_apigateway_api.validation.json
@@ -246,12 +246,12 @@
     "last_validated_date": "2024-04-15T20:47:11+00:00"
   },
   "tests/aws/services/apigateway/test_apigateway_api.py::TestApigatewayIntegration::test_create_integration_with_vpc_link": {
-    "last_validated_date": "2025-10-06T18:07:40+00:00",
+    "last_validated_date": "2025-10-08T09:05:56+00:00",
     "durations_in_seconds": {
-      "setup": 0.82,
-      "call": 1.1,
-      "teardown": 0.68,
-      "total": 2.6
+      "setup": 0.84,
+      "call": 1.59,
+      "teardown": 0.63,
+      "total": 3.06
     }
   },
   "tests/aws/services/apigateway/test_apigateway_api.py::TestApigatewayIntegration::test_delete_integration_response_errors": {
