Ignore error statuses in Thrift client response path#63
Merged
Conversation
carlosalberto
approved these changes
Mar 15, 2019
iredelmeier
approved these changes
Mar 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Satellite is backed by an ELB/ALB/other that transmits 5xx/4xx with some sort of non-Thrift, non-binary message, the Thrift client will attempt to parse this message as binary and fail. This process causes a 10x memory spike on the python process which can lead to erroneous OOM indicators.
This PR also removes the make thrift target, as we are editing generated files in this PR.