Refactor packfile code to use zstream abstraction#5340
Conversation
|
/rebuild |
|
Sorry @pks-t, an error occurred while trying to requeue the build. |
4f17339 to
e0cf8f9
Compare
While we do have a zstream abstraction that encapsulates all the calls to zlib as well as its error handling, we do not use it in our pack file code. Refactor it to make the code a lot easier to understand.
While we do have a `git_zstream` abstraction that encapsulates all the calls to zlib as well as its error handling, we do not use it in our pack file code. Refactor it to make the code a lot easier to understand.
|
The code tended to get stuck randomly depending on how fast bytes came in through the network layer. The issue is taht I tried fixing Thus: never use |
e0cf8f9 to
2dc7b5e
Compare
|
Yup, green now. @ethomson, want to have another look? As said, the only change was to replace |
|
Thanks for the ping @pks-t - I restarted the build and then forgot about it. |
While investigating #5324, I noticed that the zlib-related code in packfile looks mighty complicated and could use some love. I thus refactored it to use our own
git_zstreamabstraction, which is a much nicer interface.