open:fix memory leak when passing NULL to git_repository_open_ext#5224
Merged
Conversation
ethomson
reviewed
Sep 10, 2019
| &gitdir, &workdir, &gitlink, &commondir, start_path, flags, ceiling_dirs); | ||
|
|
||
| if (error < 0 || !repo_ptr) | ||
| if (error < 0 || !repo_ptr) { |
Member
There was a problem hiding this comment.
Instead of adding duplicate frees here, I would encourage you to jump to the cleanup label so that we can consolidate cleanup in a single place. That's the general pattern we try to use, it makes it less likely that we would end up freeing in one return path but not the other if we end up adding new allocations (for instance).
Contributor
Author
There was a problem hiding this comment.
That makes sense, I've updated the review. I initialised 'repo' to NULL in order to handle the cleanup case where error < 0 and repo_ptr is NULL.
Member
|
Nice catch. A minor request for a stylistic tweak, if you don't mind. |
ethomson
approved these changes
Sep 11, 2019
Member
|
Looks great! Thanks for finding this and the helpful pull request. Love that you added a test for it! 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an example on the website for checking if a directory looks like a repository:
https://libgit2.org/docs/guides/101-samples/#repositories_openable
This example leaks memory. This pull request includes a test point which leaks memory and is caught by valgrind, plus a fix in git_repository_open_ext to dispose of buffers on the early return.