Skip to content

ntlm: fix failure to find openssl headers#5216

Merged
ethomson merged 1 commit into
libgit2:masterfrom
stinb:ntlm-openssl-headers
Sep 12, 2019
Merged

ntlm: fix failure to find openssl headers#5216
ethomson merged 1 commit into
libgit2:masterfrom
stinb:ntlm-openssl-headers

Conversation

@hackhaslam
Copy link
Copy Markdown
Contributor

Building the NTLM module with OpenSSL chosen as the HTTPS backend results in file-not-found errors for OpenSSL headers. I gather that this was added in #5052. I'm not sure if this is the most appropriate fix, but it works for me.

@ethomson
Copy link
Copy Markdown
Member

Huh! That's surprising - I'm curious if there's something different about your setup than our CI... do you know if there's anything obviously different?

@hackhaslam
Copy link
Copy Markdown
Contributor Author

I suppose that the difference is that those instances are relying on the system openssl dev package which installs headers in /usr/include? I'm running cmake with a flag to get it to find my own openssl that I built elsewhere. I'm just guessing.

@ethomson
Copy link
Copy Markdown
Member

I suppose that the difference is that those instances are relying on the system openssl dev package which installs headers in /usr/include? I'm running cmake with a flag to get it to find my own openssl that I built elsewhere. I'm just guessing.

Nice, thanks for the info. I wonder if I'll need to do a similar thing for mbedTLS or something. I'll play around a bit.

@pks-t
Copy link
Copy Markdown
Member

pks-t commented Sep 12, 2019

Nice, thanks for the info. I wonder if I'll need to do a similar thing for mbedTLS or something. I'll play around a bit.

Yes, definitely, this will fail whenever the SSL implementation headers are in a location that is not part of the standard include search path. So the fix looks good to me and should be applied, probably with additional fixes for the other libraries. Happy to merge this single fix as a standalone, though.

@ethomson
Copy link
Copy Markdown
Member

Yes, definitely, this will fail whenever the SSL implementation headers are in a location that is not part of the standard include search path. So the fix looks good to me and should be applied, probably with additional fixes for the other libraries. Happy to merge this single fix as a standalone, though.

Yeah, I haven't played around a bit yet. I'll merge as-is and revisit other implementations when I have some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants