This repository was archived by the owner on Apr 2, 2019. It is now read-only.
WIP: Inject config for maxzoom#4
Closed
mattflaschen wants to merge 1 commit into
Closed
Conversation
This allows different stacks to use their own setting while reducing hard-coding. This is based off a random tag (0.0.17), since that is the only way I can get it to work with update-snapshot-dep. It needs to be rebased. Bug: T186780
mattflaschen
pushed a commit
to mattflaschen/kartotherian
that referenced
this pull request
Feb 10, 2018
This allows different stacks to use their own setting while reducing hard-coding. Works with kartotherian/server#4 Bug: T186780
Member
|
@mattflaschen thx for the PR, but this is not a good approach (although a fairly creative). Kartotherian already supports the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows different stacks to use their own setting while
reducing hard-coding.
This is based off a random tag (0.0.17), since that is the only way I can
get it to work with update-snapshot-dep. It needs to be rebased.
Bug: T186780