Skip to content

Improve alias redefinition warnings #9447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
headius merged 5 commits into from
Jun 13, 2026
+27 −14
Merged

Improve alias redefinition warnings #9447

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b244334
Single warning call for redefinition warning
headius May 20, 2026
79ec0fa
Switch DynamicMethod aliased check to a boolean
headius May 20, 2026
b9c81c9
Clean up imports
headius May 20, 2026
f7352f0
Mark target method aliased even if same
headius May 20, 2026
ac0bf67
Check for aliasing on the target method
headius Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Single warning call for redefinition warning 
Make these a single warning call to be a single write as in CRuby.
  • Loading branch information
@headius
headius committed May 20, 2026
commit b2443349a513523f2adb2cb11723f81fcfaf5bc5
10 changes: 6 additions & 4 deletions core/src/main/java/org/jruby/RubyModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5622,10 +5622,12 @@ public synchronized <T extends RubyModule> T defineAlias(ThreadContext context,

DynamicMethod method = getMethods().get(name);
if (method != null && entry.method.getRealMethod() != method.getRealMethod() && !method.isUndefined()) {
if (method.getRealMethod().getAliasCount() == 0) warning(context, "method redefined; discarding old " + name);

if (method instanceof PositionAware posAware) {
context.runtime.getWarnings().warning(ID.REDEFINING_METHOD, posAware.getFile(), posAware.getLine() + 1, "previous definition of " + name + " was here");
if (method.getRealMethod().getAliasCount() == 0) {
if (method instanceof PositionAware posAware) {
warning(context, "method redefined; discarding old " + name + "\n" + posAware.getFile() + ":" + (posAware.getLine() + 1) + ": warning: previous definition of " + name + " was here");
} else {
warning(context, "method redefined; discarding old " + name);
}
}
}

Expand Down