Skip to content

Commit 7037fac

Browse files
committed
Build: Remove package-lock.json, add it to .gitignore
npm 5, even the version included in the latest Node.js 8.5.0 re-generates `package-lock.json` on each install. And when it does on a system that doesn't support all the optional dependencies that are supported on the OS where the lockfile was generated, it removes those optional deps from the lockfile. The effect is that everyone firing `npm install` on our repo on any OS other than macOS will immediately get a dirty state of the repo as the `fsevents` dependency subtree gets removed from `package-lock.json`. That's a really bad experience. This commit removes package-lock.json from the repository and adds it to .gitignore. We'll start committing the file again once the issue is resolved on npm's part. Fixes gh-3792
1 parent 81be78e commit 7037fac

2 files changed

Lines changed: 1 addition & 5624 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
.bower.json
99
.sizecache.json
1010
yarn.lock
11+
package-lock.json
1112

1213
npm-debug.log*
1314

0 commit comments

Comments
 (0)