Skip to content

fix(playground): update template generator to support Angular standalone #3983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandyscarney merged 4 commits into from
Dec 31, 2024
Merged

fix(playground): update template generator to support Angular standalone #3983

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26d4428
fix(playground): update template generator to support angular standalone
brandyscarney Dec 30, 2024
8f935df
fix(playground): update react to support multiple lines
brandyscarney Dec 30, 2024
acf0966
Merge branch 'main' into fix-playground-templates
brandyscarney Dec 31, 2024
65d7678
fix(playground): css file should always be included
brandyscarney Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(playground): update react to support multiple lines
  • Loading branch information
@brandyscarney
brandyscarney committed Dec 30, 2024
commit 8f935df353c10cf14de329a9078645763aa1220d
6 changes: 5 additions & 1 deletion _templates/playground/new/react.md.ejs.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ import { <%= pascalComponent %> } from '@ionic/react';<% if (css){ %>
import './main.css';<% } %>

function Example() {
return <<%= pascalComponent %>></<%= pascalComponent %>>;
return (
<>
<<%= pascalComponent %>></<%= pascalComponent %>>

@brandyscarney brandyscarney Dec 30, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was made because running npm run lint after adding a new playground was removing the () but this makes it so it passes lint and supports adding more child components.

</>
);
}
export default Example;
```