Merge helm charts by findingrish · Pull Request #80 · hypertrace/hypertrace-alert-engine

findingrish · 2021-11-05T11:42:09Z

codecov · 2021-11-05T11:43:42Z

Codecov Report

Merging #80 (bd8a2ee) into main (38be4c8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #80   +/-   ##
=========================================
  Coverage     70.59%   70.59%           
  Complexity      154      154           
=========================================
  Files            29       29           
  Lines          1146     1146           
  Branches         57       57           
=========================================
  Hits            809      809           
  Misses          285      285           
  Partials         52       52

Flag	Coverage Δ
integration	`70.59% <ø> (ø)`
unit	`56.32% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38be4c8...bd8a2ee. Read the comment docs.

aaron-steinfeld · 2021-11-05T15:25:38Z


-SUB_PROJECTS_DIRS="./hypertrace-alert-engine ./metric-anomaly-task-manager"
-
 subcommand=$1; shift


Why is there a script here? Please use the shared github actions:

Example of packing and publishing:
https://github.com/hypertrace/config-service/blob/777df107b0141eb3368516c6527b4b846ea2d539/.github/workflows/publish.yml#L58-L62

Example of validating:
https://github.com/hypertrace/config-service/blob/777df107b0141eb3368516c6527b4b846ea2d539/.github/workflows/pr-test.yml#L68-L69

aaron-steinfeld · 2021-11-05T15:26:58Z

@@ -0,0 +1,7 @@
+{{- define "metricanomalydetector.image" -}}


could probably share this if you wanted to, same logic as earlier.

aaron-steinfeld · 2021-11-05T15:28:23Z

@@ -65,7 +65,7 @@ spec:
            - name: LOG4J_CONFIGURATION_FILE
              value: "/var/{{ .Chart.Name }}/log/log4j2.properties"
            - name: JAVA_TOOL_OPTIONS


JAVA_TOOL_OPTIONS shouldn't be used, use JAVA_OPTS instead https://github.com/hypertrace/config-service/blob/777df107b0141eb3368516c6527b4b846ea2d539/helm/templates/deployment.yaml#L65-L66

aaron-steinfeld · 2021-11-05T15:30:42Z

-            initialDelaySeconds: {{ int .Values.livenessProbe.initialDelaySeconds }}
-            periodSeconds: {{ int .Values.livenessProbe.periodSeconds }}
+            initialDelaySeconds: {{ int .Values.metricAnomalyTaskManagerConfig.livenessProbe.initialDelaySeconds }}
+            periodSeconds: {{ int .Values.metricAnomalyTaskManagerConfig.livenessProbe.periodSeconds }}


This is outside the scope of this PR, but switching to real probes rather than these TCP probes is something we should work to do on any new service. Series of PRs where I added to attribute service:
hypertrace/attribute-service#100
hypertrace/attribute-service#101
hypertrace/attribute-service#102

hypertrace/hypertrace#319

aaron-steinfeld · 2021-11-05T15:37:30Z

+  notificationChannelsConfig:
+    name: hypertrace-alert-engine-notification-channels-config
+    channels:
+      [


These examples shouldn't be in the values

they can be kept empty and finally be overridden by the user?

These are the defaults right? generally, these would be created by users at runtime, not as server config.

these are default file based rules (have to be passed through helm override)

aaron-steinfeld · 2021-11-05T15:37:56Z

+
+  queryService:
+    host: query-service
+    port: 9012


values should be based on the standalone ports

aaron-steinfeld

Admittedly just did a quick scan, but seems fine. Assuming the configs themselves were previously reviewed.

aaron-steinfeld · 2021-11-05T20:57:03Z

-
-      - name: validate charts
-        run: ./.github/workflows/helm.sh validate
+          args: build -x avroCompatibilityCheck dockerBuildImages


why is the compatibility check disabled?

Since the avro was not published, will enable.

github-actions · 2021-11-06T07:25:29Z

Unit Test Results

  9 files ±0   9 suites ±0 2m 46s ⏱️ +12s
21 tests ±0 19 ✔️ ±0 2 💤 ±0 0 ❌ ±0

Results for commit 2d50ffd. ± Comparison against base commit 38be4c8.

rish691 added 2 commits November 5, 2021 16:45

delete helm files for task manager

10a55c0

Add single chart

6015c8d

This comment has been minimized.

Sign in to view

findingrish requested a review from kotharironak November 5, 2021 13:12

Make serde and schema registry url configurable

7bd30fa

This comment has been minimized.

Sign in to view

update helm.sh

eb3f778

This comment has been minimized.

Sign in to view

fix helm config

9d1f533

This comment has been minimized.

Sign in to view

Add kafka topic creator dep

b4ff8d5

This comment has been minimized.

Sign in to view

findingrish requested review from aaron-steinfeld and ravisingal November 5, 2021 15:21

Update helm configs

333ddca

This comment has been minimized.

Sign in to view

aaron-steinfeld reviewed Nov 5, 2021

View reviewed changes

rish691 added 5 commits November 5, 2021 21:19

fix typo

1308b92

Remove example rules

370b7c2

Replace JAVA_TOOL_OPTIONS env var with JAVA_OPTS

ad88c66

common helpers

f7fee71

Use standard gha for validating and publishing charts

b616055

This comment has been minimized.

Sign in to view

Update port

9bd788a

This comment has been minimized.

Sign in to view

findingrish mentioned this pull request Nov 5, 2021

Use real probes instead of tcp in deployment hypertrace/hypertrace#319

Open

minor change

bd8a2ee

This comment has been minimized.

Sign in to view

aaron-steinfeld approved these changes Nov 5, 2021

View reviewed changes

findingrish merged commit 2d50ffd into main Nov 6, 2021

findingrish deleted the merge-helm-charts branch November 6, 2021 07:18


		SUB_PROJECTS_DIRS="./hypertrace-alert-engine ./metric-anomaly-task-manager"

		subcommand=$1; shift

Conversation

findingrish commented Nov 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Nov 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

aaron-steinfeld left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Nov 6, 2021

Unit Test Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

findingrish commented Nov 5, 2021 •

edited

Loading

codecov Bot commented Nov 5, 2021 •

edited

Loading