Check and set appropriate method's aliased flag

headius · headius · commit 0bff787113a1 · 2026-05-20T01:29:03.000-05:00
The exact old method should be marked as aliased, so if re-aliased back again it won't trigger a warning. See jruby#9447
diff --git a/core/src/main/java/org/jruby/RubyModule.java b/core/src/main/java/org/jruby/RubyModule.java
@@ -5625,7 +5625,7 @@ public synchronized <T extends RubyModule> T defineAlias(ThreadContext context,
 
         DynamicMethod method = getMethods().get(name);
         if (method != null && entry.method.getRealMethod() != method.getRealMethod() && !method.isUndefined()) {
-            if (!method.getRealMethod().isAliased()) {
+            if (!entry.method.isAliased()) {
                 if (method instanceof PositionAware posAware) {
                     warning(context, "method redefined; discarding old " + name + "\n" + posAware.getFile() + ":" + (posAware.getLine() + 1) + ": warning: previous definition of " + name + " was here");
                 } else {
diff --git a/core/src/main/java/org/jruby/internal/runtime/methods/AliasMethod.java b/core/src/main/java/org/jruby/internal/runtime/methods/AliasMethod.java
@@ -68,7 +68,7 @@ public class AliasMethod extends DynamicMethod {
      */ 
     public AliasMethod(RubyModule implementationClass, CacheEntry entry, String newName, String oldName) {
         super(implementationClass, determineVisibility(newName, entry.method.getVisibility()), oldName);
-        entry.method.getRealMethod().setAliased();
+        entry.method.setAliased();
 
         this.entry = entry;
 
