Detect whether a file uses LF or CR+LF and follow the existing style#153
Merged
Conversation
By using `detect-newline` module https://github.com/sindresorhus/detect-newline
floridoo
pushed a commit
that referenced
this pull request
Dec 27, 2015
Detect whether a file uses LF or CR+LF and follow the existing style
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Dec 7, 2016
Unpin `gulp-sourcemaps` from `1.6.0` and update it to `^2.2.1`. This version was pinned because of a bug introduced in `v1.7.0` (PR foundation#153, issue foundation#230). The bug was resolved in `v1.7.2` (PR foundation#235) See: - gulp-sourcemaps/gulp-sourcemaps#230 - gulp-sourcemaps/gulp-sourcemaps#153 - gulp-sourcemaps/gulp-sourcemaps#235
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Dec 7, 2016
Unpin `gulp-sourcemaps` from `1.6.0` and update it to `^2.2.1`. This version was pinned because of a bug introduced in `v1.7.0` (PR foundation#153, issue foundation#230). The bug was resolved in `v1.7.2` (PR foundation#235) See: - gulp-sourcemaps/gulp-sourcemaps#230 - gulp-sourcemaps/gulp-sourcemaps#153 - gulp-sourcemaps/gulp-sourcemaps#235
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Fix #137)
This pull request is an implementation of #137 (comment).
\nor\r\nby using detect-newline module.I can add
sourceMapNewlineoption or something else to force using specific newline regardless of the detected one, but I didn't add it to this pull request because most of the users prefer the default behavior and don't need to change it. What do you think, @floridoo?