feat: mapmatching - accept GeoJSON, WKT, WKB and Polyline formats#3273
Open
karololszacki wants to merge 8 commits into
Open
feat: mapmatching - accept GeoJSON, WKT, WKB and Polyline formats#3273karololszacki wants to merge 8 commits into
karololszacki wants to merge 8 commits into
Conversation
karololszacki
changed the title
karololszacki
commented
Jan 26, 2026
Comment on lines
-125
to
-134
| private LineString readWktLineString(String wkt) { | ||
| WKTReader wktReader = new WKTReader(); | ||
| LineString expectedGeometry = null; | ||
| try { | ||
| expectedGeometry = (LineString) wktReader.read(wkt); | ||
| } catch (ParseException e) { | ||
| e.printStackTrace(); | ||
| } | ||
| return expectedGeometry; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This func was actually moved from the test file into MapMatchingResource in ee36913
Recently it got replaced with the generic version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for MapMatching in formats:
This should (partly) resolve #2773, which asked for non-gpx MapMatching.
GeoJSON parsing needed one additional import from JTS (Java Topology Suite), namely their reader.
I tried to separate changes into logical commits / steps.
I am not primarily a Java dev, but I have tried my best to stick to your conventions and to best practices in general.