This repository was archived by the owner on Apr 7, 2026. It is now read-only.
chore(spanner): add R/W multiplexed session support #3381
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| /* | ||
| * Copyright 2024 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.google.cloud.spanner; | ||
|
|
||
| import com.google.api.core.ApiFuture; | ||
| import com.google.api.core.ApiFutures; | ||
| import com.google.cloud.Timestamp; | ||
| import com.google.common.util.concurrent.MoreExecutors; | ||
| import java.util.concurrent.ExecutionException; | ||
| import java.util.concurrent.Executor; | ||
|
|
||
| /** | ||
| * Represents a {@link AsyncRunner} using a multiplexed session that is not yet ready. The execution | ||
| * will be delayed until the multiplexed session has been created and is ready. This class is only | ||
| * used during the startup of the client and the multiplexed session has not yet been created. | ||
| */ | ||
| public class DelayedAsyncRunner implements AsyncRunner { | ||
|
|
||
| private final ApiFuture<AsyncRunner> asyncRunnerFuture; | ||
|
|
||
| public DelayedAsyncRunner(ApiFuture<AsyncRunner> asyncRunnerFuture) { | ||
| this.asyncRunnerFuture = asyncRunnerFuture; | ||
| } | ||
|
|
||
| ApiFuture<AsyncRunner> getAsyncRunner() { | ||
| return ApiFutures.catchingAsync( | ||
| asyncRunnerFuture, | ||
| Exception.class, | ||
| exception -> { | ||
| if (exception instanceof InterruptedException) { | ||
| throw SpannerExceptionFactory.propagateInterrupt((InterruptedException) exception); | ||
| } | ||
| if (exception instanceof ExecutionException) { | ||
| throw SpannerExceptionFactory.causeAsRunTimeException((ExecutionException) exception); | ||
| } | ||
| throw exception; | ||
| }, | ||
| MoreExecutors.directExecutor()); | ||
| } | ||
|
|
||
| @Override | ||
| public <R> ApiFuture<R> runAsync(AsyncWork<R> work, Executor executor) { | ||
| return ApiFutures.transformAsync( | ||
| getAsyncRunner(), | ||
| asyncRunner -> asyncRunner.runAsync(work, executor), | ||
| MoreExecutors.directExecutor()); | ||
| } | ||
|
|
||
| @Override | ||
| public ApiFuture<Timestamp> getCommitTimestamp() { | ||
| return ApiFutures.transformAsync( | ||
| getAsyncRunner(), AsyncRunner::getCommitTimestamp, MoreExecutors.directExecutor()); | ||
| } | ||
|
|
||
| @Override | ||
| public ApiFuture<CommitResponse> getCommitResponse() { | ||
| return ApiFutures.transformAsync( | ||
| getAsyncRunner(), AsyncRunner::getCommitResponse, MoreExecutors.directExecutor()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| /* | ||
| * Copyright 2024 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.google.cloud.spanner; | ||
|
|
||
| import com.google.api.core.ApiFuture; | ||
| import com.google.cloud.spanner.TransactionManager.TransactionState; | ||
| import java.util.concurrent.ExecutionException; | ||
|
|
||
| /** | ||
| * Represents a {@link AsyncTransactionManager} using a multiplexed session that is not yet ready. | ||
| * The execution will be delayed until the multiplexed session has been created and is ready. This | ||
| * class is only used during the startup of the client and the multiplexed session has not yet been | ||
| * created. | ||
| */ | ||
| public class DelayedAsyncTransactionManager implements AsyncTransactionManager { | ||
|
|
||
| private final ApiFuture<AsyncTransactionManager> asyncTransactionManagerApiFuture; | ||
|
|
||
| DelayedAsyncTransactionManager( | ||
| ApiFuture<AsyncTransactionManager> asyncTransactionManagerApiFuture) { | ||
| this.asyncTransactionManagerApiFuture = asyncTransactionManagerApiFuture; | ||
| } | ||
|
|
||
| AsyncTransactionManager getAsyncTransactionManager() { | ||
| try { | ||
| return this.asyncTransactionManagerApiFuture.get(); | ||
| } catch (ExecutionException executionException) { | ||
| throw SpannerExceptionFactory.causeAsRunTimeException(executionException); | ||
| } catch (InterruptedException interruptedException) { | ||
| throw SpannerExceptionFactory.propagateInterrupt(interruptedException); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public TransactionContextFuture beginAsync() { | ||
| return getAsyncTransactionManager().beginAsync(); | ||
|
Collaborator
There was a problem hiding this comment. Same here as above: Preferably, these methods should be non-blocking if possible.
Contributor
Author
There was a problem hiding this comment. Modifying this to be non-blocking would require the method signature to be modified, which makes it impossible here. Should we just accept this as it is which means this will be blocking until a multiplexed session is available. Please let me know if there are any other ways to handle this?
Collaborator
There was a problem hiding this comment. I'm not sure I understand why the signature would need to change. The return value is a
Contributor
Author
There was a problem hiding this comment. We might need to use However, since |
||
| } | ||
|
|
||
| @Override | ||
| public ApiFuture<Void> rollbackAsync() { | ||
| return getAsyncTransactionManager().rollbackAsync(); | ||
| } | ||
|
|
||
| @Override | ||
| public TransactionContextFuture resetForRetryAsync() { | ||
| return getAsyncTransactionManager().resetForRetryAsync(); | ||
| } | ||
|
|
||
| @Override | ||
| public TransactionState getState() { | ||
| return getAsyncTransactionManager().getState(); | ||
| } | ||
|
|
||
| @Override | ||
| public ApiFuture<CommitResponse> getCommitResponse() { | ||
| return getAsyncTransactionManager().getCommitResponse(); | ||
| } | ||
|
|
||
| @Override | ||
| public void close() { | ||
| getAsyncTransactionManager().close(); | ||
| } | ||
|
|
||
| @Override | ||
| public ApiFuture<Void> closeAsync() { | ||
| return getAsyncTransactionManager().closeAsync(); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.