Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

samples: allow only one pair of region tags#532

Merged
anguillanneuf merged 4 commits into
masterfrom
anguillanneuf-patch-1
Feb 25, 2021
Merged

samples: allow only one pair of region tags#532
anguillanneuf merged 4 commits into
masterfrom
anguillanneuf-patch-1

Conversation

@anguillanneuf

Copy link
Copy Markdown
Contributor

Really odd. #527 actually messed up the README:

Screen Shot 2021-02-24 at 1 27 11 PM

@anguillanneuf anguillanneuf requested review from a team February 24, 2021 21:28
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 24, 2021
@snippet-bot

snippet-bot Bot commented Feb 24, 2021

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Feb 24, 2021
@generated-files-bot

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • samples/snippets/pom.xml

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Feb 24, 2021
@codecov

codecov Bot commented Feb 24, 2021

Copy link
Copy Markdown

Codecov Report

Merging #532 (0d967d2) into master (325fed0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #532   +/-   ##
=========================================
  Coverage     78.85%   78.85%           
  Complexity      376      376           
=========================================
  Files            27       27           
  Lines          3414     3414           
  Branches        171      171           
=========================================
  Hits           2692     2692           
  Misses          650      650           
  Partials         72       72           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 325fed0...c2f7863. Read the comment docs.

@chingor13

Copy link
Copy Markdown
Contributor

This is very odd. Try using the exclude tag syntax instead of 2 duplicate region tags (which is allowed on cloud site, but not parsed in https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/snippets.py)

@chingor13 chingor13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need the region tag to exclude

Comment thread samples/snippets/pom.xml Outdated
Comment thread samples/snippets/pom.xml Outdated
anguillanneuf and others added 2 commits February 24, 2021 14:30
Co-authored-by: Jeff Ching <chingor@google.com>
Co-authored-by: Jeff Ching <chingor@google.com>
@anguillanneuf anguillanneuf merged commit 6f172ae into master Feb 25, 2021
@anguillanneuf anguillanneuf deleted the anguillanneuf-patch-1 branch February 25, 2021 00:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants