Skip to content
This repository was archived by the owner on Dec 3, 2023. It is now read-only.

feat: support conditional policies #110

Merged
frankyn merged 36 commits into from
Feb 27, 2020
Merged

feat: support conditional policies #110

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
67e52ce
Base implementation
Dec 17, 2019
84fcfea
Update with unit tests
Dec 20, 2019
145f7a0
lint
Dec 20, 2019
ac1fd6e
correct copyright date
Jan 7, 2020
2c8724b
lint
Jan 7, 2020
c90dbb0
Revert removal of helper functions
Jan 8, 2020
b0a617f
use auto-value
Jan 22, 2020
9dbfc2d
Merge branch 'master' into conditional-policy
Jan 22, 2020
54ad076
reformat Binding.java and Condition.java
Jan 22, 2020
ff49620
remove unnecessary dep
Jan 22, 2020
298b2be
code format
Jan 22, 2020
aaebba4
add dep on com.google.code.findbugs in google-cloud-core
Jan 22, 2020
a5f63ea
address comments
Feb 6, 2020
4873b73
Merge branch 'master' into conditional-policy
frankyn Feb 11, 2020
c853a84
Clean up
Feb 11, 2020
c64e55a
Merge branch 'conditional-policy' of github.com:frankyn/java-core int…
Feb 11, 2020
d2fab21
respond to comments
Feb 19, 2020
86cd863
Merge branch 'master' into conditional-policy
Feb 19, 2020
085959d
address comments
Feb 20, 2020
174e8c4
format
Feb 20, 2020
14e1aac
address feedback
Feb 21, 2020
fdb040a
remove unnecessary null check
Feb 21, 2020
42199d1
lint
Feb 21, 2020
bbb708a
address feedback
Feb 21, 2020
7f0e33e
remove ImmutableList from Binding AutoValue surface
Feb 21, 2020
108faec
address feedback
Feb 25, 2020
79126b5
split up unit test
Feb 25, 2020
505f9bc
use guava beta annotation
Feb 25, 2020
a89ef0c
surface ImmutableList<> for Binding class.
Feb 25, 2020
f0b5085
use BetaApi from api.core
Feb 25, 2020
9f5e600
return as expected
Feb 26, 2020
8580f5a
partial addressing of feedback
Feb 26, 2020
9fe4358
address feedback pt2
Feb 26, 2020
8f48a15
address remaining feedback
Feb 26, 2020
615ba06
Merge branch 'master' into conditional-policy
Feb 26, 2020
2b56641
address one last feedback
Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unnecessary dep
  • Loading branch information
Frank Natividad committed Jan 22, 2020
commit ff496207608c756463fa3a4610e3c4731c917e21
5 changes: 0 additions & 5 deletions google-cloud-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,6 @@
<optional>true</optional>

@elharo elharo Feb 20, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure this can be optional.

</dependency>
<dependency>
<groupId>com.google.auto.value</groupId>
<artifactId>auto-value</artifactId>
<optional>true</optional>
</dependency>
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java-util</artifactId>
</dependency>
Expand Down
2 changes: 2 additions & 0 deletions google-cloud-core/src/main/java/com/google/cloud/Binding.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@

import com.google.auto.value.AutoValue;
import com.google.common.base.Predicates;

import com.google.common.collect.Collections2;
import com.google.common.collect.ImmutableList;

import java.util.Arrays;
import java.util.List;
import javax.annotation.Nullable;
Expand Down
6 changes: 0 additions & 6 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,12 +239,6 @@
<version>${auto-value-annotations.version}</version>
<optional>true</optional>
</dependency>
<dependency>
<groupId>com.google.auto.value</groupId>
<artifactId>auto-value</artifactId>
<version>${auto-value.version}</version>
<optional>true</optional>
</dependency>
<dependency>
<groupId>com.google.api</groupId>
<artifactId>api-common</artifactId>
Expand Down