Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

build: update samples/stylecheck to use java 11#2681

Merged
PhongChuong merged 1 commit into
mainfrom
samplesStyleJava11
Oct 3, 2024
Merged

build: update samples/stylecheck to use java 11#2681
PhongChuong merged 1 commit into
mainfrom
samplesStyleJava11

Conversation

@PhongChuong
Copy link
Copy Markdown
Contributor

This is to match new style guide as indicated in: https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md#java-version

This fixes the samples/stylecheck in PR#2649

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

 This is to match new style guide as indicated in: https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md#java-version

This fixes the samples/stylecheck in PR#2649
@PhongChuong PhongChuong requested review from a team and Neenu1995 October 3, 2024 16:33
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .github/workflows/samples.yaml

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. samples Issues that are directly related to samples. labels Oct 3, 2024
@PhongChuong PhongChuong requested a review from whuffman36 October 3, 2024 16:34
Copy link
Copy Markdown
Contributor

@whuffman36 whuffman36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhongChuong PhongChuong merged commit aaf1c2f into main Oct 3, 2024
@PhongChuong PhongChuong deleted the samplesStyleJava11 branch October 3, 2024 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants