Skip to content

proper pre-push hook implementation #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
extrawurst merged 33 commits into from
Jan 18, 2026
Merged

proper pre-push hook implementation #2811

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
2347a8b
proper pre-push hook implementation
extrawurst Dec 17, 2025
36bb24a
better error handling, fix upstream sha
extrawurst Dec 17, 2025
3b885fe
hooksresult refactor
extrawurst Dec 17, 2025
b90a365
explicit drop semantics
extrawurst Dec 17, 2025
96f18c9
feed correct stdin to pre-push hook
extrawurst Dec 17, 2025
5aab2e0
use correct remote advertised tips for pre_push hook
extrawurst Dec 17, 2025
f8ce43f
fix branch destination ref logic
extrawurst Dec 17, 2025
5d7f749
skip remote access if pre_push not set
extrawurst Dec 17, 2025
4a33af4
provide same creds to hooks call as to push
extrawurst Dec 17, 2025
a3c73ef
cleanup
extrawurst Dec 17, 2025
b1802f4
simplify and document
extrawurst Dec 17, 2025
a478074
improve error handling
extrawurst Dec 17, 2025
a81cc14
simplify stdin
extrawurst Dec 17, 2025
cf8d1cb
revert unrelated change
extrawurst Dec 17, 2025
2561dc9
add comment
extrawurst Dec 17, 2025
8d2af0e
cleanup uneeded allow
extrawurst Dec 17, 2025
bc0f381
cleanup: no need to be public
extrawurst Dec 17, 2025
b92803b
integration test
extrawurst Dec 17, 2025
61951ff
potential fix for broken pipe ci tests failing
extrawurst Dec 17, 2025
6998e42
add more logging for diagnostics
extrawurst Dec 17, 2025
d1dc562
Merge branch 'master' into pre-push-with-lfs
extrawurst Jan 15, 2026
a1ae92b
cleanup feedback review
extrawurst Jan 15, 2026
a8f80a1
clearer api design
extrawurst Jan 15, 2026
555d915
clearer api design: use did_run_hook in tests
extrawurst Jan 15, 2026
38c55af
clearer api design: use did_run_hook in tests
extrawurst Jan 16, 2026
72283e7
fix message
extrawurst Jan 16, 2026
8c3493a
remove must_use
extrawurst Jan 16, 2026
7327c28
more context
extrawurst Jan 16, 2026
a65e8b9
extend test
extrawurst Jan 16, 2026
ee16934
consolidate tests, cleanup
extrawurst Jan 16, 2026
129f481
cleanup
extrawurst Jan 16, 2026
dcd9e00
remote url lookup inside push_hook
extrawurst Jan 16, 2026
49ac056
cleanup bash based asserting
extrawurst Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup uneeded allow
  • Loading branch information
@extrawurst
extrawurst committed Dec 18, 2025
commit 8d2af0edb8b4857f34a1473c252562f08ebf0b22
2 changes: 0 additions & 2 deletions asyncgit/src/sync/hooks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@ pub fn hooks_pre_push(
}

/// Build a single pre-push update line for a branch.
#[allow(clippy::implicit_hasher)]
fn pre_push_branch_update(
repo_path: &RepoPath,
branch_name: &str,
Expand All @@ -236,7 +235,6 @@ fn pre_push_branch_update(
}

/// Build pre-push updates for tags that are missing on the remote.
#[allow(clippy::implicit_hasher)]
fn pre_push_tag_updates(
repo_path: &RepoPath,
remote: &str,
Expand Down