Skip to content

fix: resolve GitHub release asset API URL for private repo preset and workflow downloads #2855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnriem merged 7 commits into from
Jun 5, 2026
Merged

fix: resolve GitHub release asset API URL for private repo preset and workflow downloads #2855

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7e525fa
fix: resolve GitHub release asset API URL for private repo preset and…
lselvar Jun 4, 2026
b706cf3
fix: URL-encode tag in release API URL to handle special characters
mnriem Jun 5, 2026
4943ef0
test: add CLI-level tests for preset add --from GitHub release URL re…
mnriem Jun 5, 2026
0b7222a
refactor: deduplicate release URL resolution; fix test issues
mnriem Jun 5, 2026
49ecc49
fix: align resolver timeout with download timeout; add workflow CLI t…
mnriem Jun 5, 2026
0745ad2
fix: remove unused urllib.request import; add catalog workflow test
mnriem Jun 5, 2026
f00ea71
style: remove unused MagicMock imports from tests
mnriem Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
style: remove unused MagicMock imports from tests 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  • Loading branch information
@mnriem
mnriem and Copilot committed Jun 5, 2026
commit f00ea71d48e909a19041b2a35523cbb01e040ff4
2 changes: 1 addition & 1 deletion tests/test_presets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3902,7 +3902,7 @@ class TestPresetAddFromUrlResolution:
def test_preset_add_from_github_release_url_resolves_and_downloads(self, project_dir):
"""'preset add --from <github-release-url>' resolves to API asset URL."""
from typer.testing import CliRunner
from unittest.mock import patch, MagicMock
from unittest.mock import patch
from specify_cli import app
Comment thread
mnriem marked this conversation as resolved.

manifest_content = yaml.dump({
Expand Down
2 changes: 1 addition & 1 deletion tests/test_workflows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3495,7 +3495,7 @@ class TestWorkflowAddUrlResolution:
def test_workflow_add_from_github_release_url_resolves_and_downloads(self, project_dir):
"""'workflow add <github-release-url>' resolves to API asset URL."""
from typer.testing import CliRunner
from unittest.mock import patch, MagicMock
from unittest.mock import patch
from specify_cli import app
Comment thread
mnriem marked this conversation as resolved.

captured_urls = []
Expand Down
Loading