Skip to content

Overlay: Use overlay-aware CLI version when analyzing PRs #3880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 19 commits into from
May 12, 2026
Merged

Overlay: Use overlay-aware CLI version when analyzing PRs #3880

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a796e3e
Add OverlayAnalysisMatchCodeqlVersion feature flag
henrymercer May 6, 2026
b094211
Expose all enabled default CLI versions
henrymercer May 6, 2026
55d6319
Match CLI version to cached overlay-base database
henrymercer May 6, 2026
b967fdf
Add dry run mode so we can dark ship
henrymercer May 6, 2026
1b56327
Add changelog note
henrymercer May 6, 2026
817b684
Merge branch 'main' into henrymercer/overlay-match-codeql-version
henrymercer May 6, 2026
01bc9be
Filter to code scanning only
henrymercer May 7, 2026
7525c68
Nit: Dedupe languages
henrymercer May 7, 2026
efc9b0a
Improve changelog note
henrymercer May 7, 2026
0aedbb7
Merge branch 'main' into henrymercer/overlay-match-codeql-version
henrymercer May 8, 2026
4f815a6
Minor: Introduce constant to avoid duplication
henrymercer May 7, 2026
2a950b9
Enable overlay-aware version selection in `setup-codeql`
henrymercer May 8, 2026
9a85234
Add JSDoc for `getRawLanguagesNoAutodetect`
henrymercer May 8, 2026
540699d
Remove `makeOverlayMatchFeatures` indirection
henrymercer May 8, 2026
42d7f62
Remove dead code
henrymercer May 8, 2026
87ac48d
Improve error message
henrymercer May 8, 2026
b4ea7aa
Improve tests
henrymercer May 8, 2026
201a96b
Use overlay-aware version for code scanning exclusively
henrymercer May 12, 2026
8d21760
Nit: Tweak JSDoc for `getRawLanguagesNoAutodetect`
henrymercer May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add JSDoc for getRawLanguagesNoAutodetect
  • Loading branch information
@henrymercer
henrymercer committed May 8, 2026
commit 9a8523487521a38598130492b67894c80d257d22
1 change: 1 addition & 0 deletions src/config-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,7 @@ export async function getLanguages(
return languages;
}

/** Parses the `languages` input into a list of languages without checking if they are supported by CodeQL. */

@mbg mbg May 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Really all this does is split a comma-separated string into an array, removes excess space characters, converts the strings to lower-case, and removes empty elements. The current description might suggest that something more specific to languages is happening here. How about:

Splits a comma-separated string into an array. Excess spaces are removed and all characters are converted to lower-case.

@henrymercer henrymercer May 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a little implementation specific. Perhaps the main opposition is with "Parses"? I'll update that.

export function getRawLanguagesNoAutodetect(
languagesInput: string | undefined,
): string[] {
Expand Down