Skip to content

Test connections to private registries in start-proxy #3466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbg merged 21 commits into from
Feb 11, 2026
Merged

Test connections to private registries in start-proxy #3466

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
d2901f5
Make FFs available in `start-proxy` action
mbg Jan 28, 2026
310177a
Merge branch 'main' into mbg/start-proxy/test-connections
mbg Feb 9, 2026
93302bc
Move `Credential` type
mbg Feb 9, 2026
70eae15
Break up `Credential` type into two interfaces
mbg Feb 9, 2026
b030333
Add explicit dependency on `https-proxy-agent`
mbg Feb 9, 2026
c4717c9
Add `ProxyInfo` type and return from `startProxy`
mbg Feb 10, 2026
c7eff3f
Add `StartProxyConnectionChecks` feature
mbg Feb 10, 2026
01ee641
Test connections to registries, if FF is enabled
mbg Feb 10, 2026
9f2f6d0
Remove superflous log message
mbg Feb 10, 2026
700fc11
Add missing `else`
mbg Feb 10, 2026
4d44b57
Type that registries must have either an `url` or a `host`
mbg Feb 10, 2026
5135700
Add a 5s timeout to requests
mbg Feb 10, 2026
c4b0f60
Remove superfluous error handling details
mbg Feb 10, 2026
27b3b65
Remove unnecessary test assertions
mbg Feb 11, 2026
0387f55
Fix outdated comment
mbg Feb 11, 2026
4d0bec1
Rename types
mbg Feb 11, 2026
bd36637
Require validated `Credential` for `credentialToStr`
mbg Feb 11, 2026
e114998
Add test for missing type
mbg Feb 11, 2026
555ee17
Remove unused `logger` in `NetworkReachabilityBackend`
mbg Feb 11, 2026
2b5b614
Add `timeout` event handler
mbg Feb 11, 2026
efb92e2
Skip checks for non-URLs for now
mbg Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add StartProxyConnectionChecks feature
  • Loading branch information
@mbg
mbg committed Feb 10, 2026
commit c7eff3f0b1ef5122cdd10ca453b879148a75afe7
5 changes: 5 additions & 0 deletions lib/analyze-action-post.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions lib/analyze-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions lib/autobuild-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions lib/init-action-post.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions lib/init-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions lib/resolve-environment-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions lib/setup-codeql-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions lib/start-proxy-action-post.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions lib/start-proxy-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions lib/upload-lib.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions lib/upload-sarif-action-post.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions lib/upload-sarif-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions src/feature-flags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ export enum Feature {
QaTelemetryEnabled = "qa_telemetry_enabled",
/** Note that this currently only disables baseline file coverage information. */
SkipFileCoverageOnPrs = "skip_file_coverage_on_prs",
StartProxyConnectionChecks = "start_proxy_connection_checks",
UploadOverlayDbToApi = "upload_overlay_db_to_api",
UseRepositoryProperties = "use_repository_properties",
ValidateDbConfig = "validate_db_config",
Expand Down Expand Up @@ -297,6 +298,11 @@ export const featureConfig = {
// cannot be found when interpreting results.
minimumVersion: undefined,
},
[Feature.StartProxyConnectionChecks]: {
defaultValue: false,
envVar: "CODEQL_ACTION_START_PROXY_CONNECTION_CHECKS",
minimumVersion: undefined,
},
[Feature.UploadOverlayDbToApi]: {
defaultValue: false,
envVar: "CODEQL_ACTION_UPLOAD_OVERLAY_DB_TO_API",
Expand Down