-
Notifications
You must be signed in to change notification settings - Fork 474
Test connections to private registries in start-proxy
#3466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+14,970
−14,036
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
d2901f5
Make FFs available in `start-proxy` action
mbg 310177a
Merge branch 'main' into mbg/start-proxy/test-connections
mbg 93302bc
Move `Credential` type
mbg 70eae15
Break up `Credential` type into two interfaces
mbg b030333
Add explicit dependency on `https-proxy-agent`
mbg c4717c9
Add `ProxyInfo` type and return from `startProxy`
mbg c7eff3f
Add `StartProxyConnectionChecks` feature
mbg 01ee641
Test connections to registries, if FF is enabled
mbg 9f2f6d0
Remove superflous log message
mbg 700fc11
Add missing `else`
mbg 4d44b57
Type that registries must have either an `url` or a `host`
mbg 5135700
Add a 5s timeout to requests
mbg c4b0f60
Remove superfluous error handling details
mbg 27b3b65
Remove unnecessary test assertions
mbg 0387f55
Fix outdated comment
mbg 4d0bec1
Rename types
mbg bd36637
Require validated `Credential` for `credentialToStr`
mbg e114998
Add test for missing type
mbg 555ee17
Remove unused `logger` in `NetworkReachabilityBackend`
mbg 2b5b614
Add `timeout` event handler
mbg efb92e2
Skip checks for non-URLs for now
mbg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add
ProxyInfo type and return from startProxy
- Loading branch information
commit c4717c9c748f6b31c0eae0edf9f9d4b5227b9fa4
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.