Skip to content

Tolerate errors loading repository properties #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 16 commits into from
Jan 28, 2026
Merged

Tolerate errors loading repository properties #3421

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e142eee
Only load repository properties for repos owned by orgs
henrymercer Jan 23, 2026
4e14537
Improve logging when no known repository properties found
henrymercer Jan 23, 2026
f4b47e7
Add result type
henrymercer Jan 23, 2026
d9e374e
Tolerate failures loading repository properties
henrymercer Jan 23, 2026
9fda641
Prefer accessing context via `@actions/github`
henrymercer Jan 27, 2026
9ea34c5
`Result`: Make use of type hint
henrymercer Jan 27, 2026
a0671be
Add doc for `Result`
henrymercer Jan 27, 2026
e8f4871
Add some doc for `loadRepositoryProperties`
henrymercer Jan 27, 2026
5cb12c4
Include "Result" in name
henrymercer Jan 27, 2026
6a50972
Introduce `addNoLanguageDiagnostic`
henrymercer Jan 27, 2026
fbf75eb
Merge branch 'main' into henrymercer/only-request-properties-for-orgs
henrymercer Jan 27, 2026
d5dd165
Ensure default value is assignable if we have a `Failure`
henrymercer Jan 27, 2026
679da45
Add basic unit tests for `Result` class
henrymercer Jan 27, 2026
38ba96d
Merge branch 'main' into henrymercer/only-request-properties-for-orgs
henrymercer Jan 27, 2026
0720e13
Log repository owner type explicitly
henrymercer Jan 28, 2026
9aa0515
Update comments
henrymercer Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Log repository owner type explicitly
  • Loading branch information
@henrymercer
henrymercer committed Jan 28, 2026
commit 0720e13f0b9bf428e76fec0c3b8af05584ad075f
3 changes: 3 additions & 0 deletions lib/init-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/init-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,6 +812,9 @@ async function loadRepositoryProperties(
// repositories owned by users cannot have repository properties, so we can
// skip the API call entirely in that case.
const repositoryOwnerType = github.context.payload.repository?.owner.type;
Comment thread
mbg marked this conversation as resolved.
logger.debug(
`Repository owner type is '${repositoryOwnerType ?? "unknown"}'.`,
);
if (repositoryOwnerType === "User") {
logger.debug(
"Skipping loading repository properties because the repository is owned by a user and " +
Expand Down
Loading