Revert "ref(core): Wrap scopes in WeakRef when storing scopes on spans"#17731
Closed
andreiborza wants to merge 1 commit into
Closed
Revert "ref(core): Wrap scopes in WeakRef when storing scopes on spans"#17731andreiborza wants to merge 1 commit into
WeakRef when storing scopes on spans"#17731andreiborza wants to merge 1 commit into
Conversation
…n spans …" This reverts commit b685be6.
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Member
Author
|
The WeakRef change has improved memory profiles and we'll keep it around for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #17712
Keeping this ready just in case there are issues with the WeakRef approach.