Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
7a7d63f
feat(extend-app-start): Add IAppStartExtender bridge and SentryOptionโ€ฆ
buenaflor Jun 23, 2026
313fff1
chore(extend-app-start): Annotate NoOpAppStartExtender internal and fโ€ฆ
buenaflor Jun 23, 2026
540931a
refactor(extend-app-start): Rename finishAppStart to finishExtendedApโ€ฆ
buenaflor Jun 25, 2026
7dfe617
feat(extend-app-start): Extract AppStartExtension component for the Aโ€ฆ
buenaflor Jun 23, 2026
4d0c97d
refactor(extend-app-start): Inject logger into AppStartExtension instโ€ฆ
buenaflor Jun 25, 2026
b5ac7f5
refactor(extend-app-start): Return ExtendedAppStart from the listenerโ€ฆ
buenaflor Jun 25, 2026
81efded
chore(extend-app-start): Remove redundant comments and rename reset tโ€ฆ
buenaflor Jun 25, 2026
3cc743e
refactor(extend-app-start): Inline the logger lookup instead of injecโ€ฆ
buenaflor Jun 25, 2026
1dafb9b
chore(extend-app-start): Drop the class and listener javadocs on AppSโ€ฆ
buenaflor Jun 25, 2026
8548b4d
chore(extend-app-start): Trim finishTransaction/getExtendedEndTime coโ€ฆ
buenaflor Jun 25, 2026
01b1dc4
refactor(extend-app-start): Rename AppStartExtension.finishAppStart tโ€ฆ
buenaflor Jun 25, 2026
d996425
feat(extend-app-start): Eagerly create the extended App Start transacโ€ฆ
buenaflor Jun 24, 2026
51e4969
chore(extend-app-start): Drop the redundant foreground-check comment โ€ฆ
buenaflor Jun 25, 2026
4c1f0d7
test(extend-app-start): Replace the no-op finish test with isExtendedโ€ฆ
buenaflor Jun 25, 2026
48bb3a1
test(extend-app-start): Drop the no-value getAppStartExtension test aโ€ฆ
buenaflor Jun 25, 2026
05a9df2
chore(extend-app-start): Drop the redundant foreground-check comment โ€ฆ
buenaflor Jun 25, 2026
5830303
test(extend-app-start): Drop the no-value getAppStartExtension test aโ€ฆ
buenaflor Jun 25, 2026
ec4da6c
test(extend-app-start): Drop the no-op finishExtendedAppStart test
buenaflor Jun 25, 2026
9fa64fd
Merge branch 'feat/app-start-extension-android' into feat/app-start-eโ€ฆ
buenaflor Jun 25, 2026
38f83e1
chore(extend-app-start): Trim and de-duplicate comments in the eager โ€ฆ
buenaflor Jun 25, 2026
55decba
chore(extend-app-start): Clarify the extensionActive comment
buenaflor Jun 25, 2026
d2c16a2
fix(extend-app-start): Read the extended span finish date, not its fiโ€ฆ
buenaflor Jun 25, 2026
f0a85b0
Merge branch 'feat/app-start-extension-android' into feat/app-start-eโ€ฆ
buenaflor Jun 25, 2026
b6dd76e
fix(extend-app-start): End the extended transaction at the extended sโ€ฆ
buenaflor Jun 25, 2026
66cd87d
Merge branch 'feat/app-start-extension-android' into feat/app-start-eโ€ฆ
buenaflor Jun 25, 2026
571416e
ref(extend-app-start): Rename extended app start span op to app.startโ€ฆ
buenaflor Jun 25, 2026
ff8c056
fix(extend-app-start): Guard extendAppStartListener with the lock
buenaflor Jun 26, 2026
b4f34ce
Merge branch 'feat/app-start-extension-android' into feat/app-start-eโ€ฆ
buenaflor Jun 26, 2026
1eb12d5
fix(extend-app-start): Fix headless app start end time and duplicate txn
buenaflor Jun 26, 2026
b5bf4ec
style(extend-app-start): Trim low-value comments in the headless fix
buenaflor Jun 26, 2026
bb88dad
style(extend-app-start): Drop redundant extend-listener comment
buenaflor Jun 26, 2026
85e23d8
style(extend-app-start): Trim redundant comments in onActivityCreated
buenaflor Jun 26, 2026
f2d1c34
style(extend-app-start): Remove explanatory comments in app start paths
buenaflor Jun 26, 2026
d2df48b
fix(extend-app-start): Consume stored app start trace on the extensioโ€ฆ
buenaflor Jun 26, 2026
142a9d2
fix(extend-app-start): Only the launch activity attaches the app starโ€ฆ
buenaflor Jun 26, 2026
dd7b3e0
Format code
getsentry-bot Jun 26, 2026
e26ee97
style(extend-app-start): Trim verbose finishTransaction comment
buenaflor Jun 26, 2026
b7da10f
Merge branch 'feat/app-start-extension-android' into feat/app-start-eโ€ฆ
buenaflor Jun 26, 2026
0de722b
style(extend-app-start): Trim verbose comments in app start paths
buenaflor Jun 26, 2026
c2cdb14
Merge remote-tracking branch 'origin/feat/app-start-extension-materiaโ€ฆ
buenaflor Jun 26, 2026
83e2058
fix(extend-app-start): Read finish date in getExtendedAppStartSpan
buenaflor Jun 29, 2026
2a02616
Merge branch 'feat/app-start-extension-android' into feat/app-start-eโ€ฆ
buenaflor Jun 29, 2026
53cf7db
style(extend-app-start): Trim duplicated reentrancy comment in getExtโ€ฆ
buenaflor Jun 29, 2026
11d704d
style(extend-app-start): Keep trimmed reentrancy comment within line โ€ฆ
buenaflor Jun 29, 2026
df8cfe4
Merge branch 'feat/app-start-extension-android' into feat/app-start-eโ€ฆ
buenaflor Jun 29, 2026
b442c1e
style(extend-app-start): Drop two line-narrating test comments
buenaflor Jun 29, 2026
dc76d9a
style(extend-app-start): Reword getExtendedAppStartSpan reentrancy coโ€ฆ
buenaflor Jun 29, 2026
642cfb0
Merge branch 'feat/app-start-extension-android' into feat/app-start-eโ€ฆ
buenaflor Jun 29, 2026
33a6aa0
refactor(extend-app-start): Rename isAppStartWindowOpen to canExtendAโ€ฆ
buenaflor Jun 29, 2026
e12f7b0
Merge branch 'feat/app-start-extension-android' into feat/app-start-eโ€ฆ
buenaflor Jun 29, 2026
210b4ee
test(extend-app-start): Drop redundant getExtendedAppStartSpan finishโ€ฆ
buenaflor Jun 29, 2026
9ebdd09
Merge branch 'feat/app-start-extension-android' into feat/app-start-eโ€ฆ
buenaflor Jun 29, 2026
824c12f
test(extend-app-start): Drop narrating comments from app start tests
buenaflor Jun 29, 2026
bdadd2b
feat(extend-app-start): Add setData and isExtended to AppStartExtension
buenaflor Jun 29, 2026
d87e908
Merge branch 'feat/app-start-extension-android' into feat/app-start-eโ€ฆ
buenaflor Jun 29, 2026
c861ba9
refactor(extend-app-start): Name app start branching booleans by intent
buenaflor Jun 29, 2026
b11b0fa
fix(extend-app-start): Make shouldSendStartMeasurements volatile
buenaflor Jun 29, 2026
d8ffbbc
Merge branch 'feat/app-start-extension-android' into feat/app-start-eโ€ฆ
buenaflor Jun 29, 2026
04c2835
docs(extend-app-start): Explain why AppStartExtension holds span and โ€ฆ
buenaflor Jul 2, 2026
b8779ca
feat(extend-app-start): Return null from getExtendedAppStartSpan whenโ€ฆ
buenaflor Jul 2, 2026
adedde8
Merge branch 'feat/app-start-extension-core' into feat/app-start-exteโ€ฆ
buenaflor Jul 2, 2026
8420f74
feat(extend-app-start): Return null from AppStartExtension.getExtendeโ€ฆ
buenaflor Jul 2, 2026
fd32a34
Merge branch 'feat/app-start-extension-android' into feat/app-start-eโ€ฆ
buenaflor Jul 2, 2026
3d4d55a
test(extend-app-start): Assert null extended span now that getExtendeโ€ฆ
buenaflor Jul 2, 2026
958b74c
docs(extend-app-start): Explain single-use app start sampling decision
buenaflor Jul 3, 2026
9196ec9
fix(extend-app-start): Bound the trace continuation window after an eโ€ฆ
buenaflor Jul 3, 2026
a6846bd
fix(extend-app-start): Skip warm-start reclassification while the extโ€ฆ
buenaflor Jul 3, 2026
bcb53b0
test(extend-app-start): Remove NoOpAppStartExtenderTest per PR review
buenaflor Jul 6, 2026
c553a7a
Merge remote-tracking branch 'origin/feat/extend-app-start' into featโ€ฆ
buenaflor Jul 6, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(extend-app-start): Drop narrating comments from app start tests
The test names describe the scenarios; the inline comments restated them.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
  • Loading branch information
buenaflor and claude committed Jun 29, 2026
commit 824c12f81a682bedc5bebccefeeb5c5c1f48fa84
Original file line number Diff line number Diff line change
Expand Up @@ -367,16 +367,12 @@ class ActivityLifecycleIntegrationTest {
fixture.createdTransactions.filter {
it.spanContext.operation == ActivityLifecycleIntegration.STANDALONE_APP_START_OP
}
// The eager app.start txn is reused; no second one is created at the first activity.
assertEquals(1, appStartTransactions.size)
// The screen (first activity) is attached to the eager app.start, matching foreground
// standalone.
assertEquals("Activity", appStartTransactions.single().getData("app.vitals.start.screen"))
val uiLoadTransaction =
fixture.createdTransactions.single {
it.spanContext.operation == ActivityLifecycleIntegration.UI_LOAD_OP
}
// ui.load shares the eager app.start trace.
assertEquals(
appStartTransactions.single().spanContext.traceId,
uiLoadTransaction.spanContext.traceId,
Expand Down Expand Up @@ -410,7 +406,6 @@ class ActivityLifecycleIntegrationTest {
sut.onActivityPaused(firstActivity)
sut.onActivityCreated(secondActivity, fixture.bundle)

// The second activity must not continue the already-finished extended app.start trace.
assertNotEquals(appStartTraceId, fixture.createdTransactions.last().spanContext.traceId)
}

Expand Down Expand Up @@ -459,7 +454,6 @@ class ActivityLifecycleIntegrationTest {
it.spanContext.operation == ActivityLifecycleIntegration.STANDALONE_APP_START_OP
}

// waitForChildren keeps the app start transaction open until the extension finishes.
appStartTransaction.finish(SpanStatus.OK)
assertFalse(appStartTransaction.isFinished)

Expand Down Expand Up @@ -487,7 +481,6 @@ class ActivityLifecycleIntegrationTest {
it.operation == ActivityLifecycleIntegration.APP_START_EXTENDED_OP
}
)
// Headless finishes the transaction, but waitForChildren holds it until the extension finishes.
assertFalse(transaction.isFinished)

AppStartMetrics.getInstance().appStartExtension.finishExtendedAppStart()
Expand Down Expand Up @@ -522,8 +515,6 @@ class ActivityLifecycleIntegrationTest {

prepareHeadlessAppStart(appStartType = AppStartType.COLD)
AppStartMetrics.getInstance().appStartExtension.extendAppStart()
// Finish and send the extension's app.start (onAppStartSpansSent is normally driven by the
// event processor) before the headless idle check runs.
AppStartMetrics.getInstance().appStartExtension.finishExtendedAppStart()
AppStartMetrics.getInstance().onAppStartSpansSent()
val transactionsBefore = fixture.createdTransactions.size
Expand Down Expand Up @@ -562,8 +553,6 @@ class ActivityLifecycleIntegrationTest {
sut.onActivityCreated(activity, fixture.bundle)
assertTrue(AppStartMetrics.getInstance().appStartExtension.isActive)

// The eager txn is owned by the extension, not the integration's appStartTransaction field, so
// the per-activity cleanup can't cancel it.
sut.onActivityDestroyed(activity)
assertTrue(AppStartMetrics.getInstance().appStartExtension.isActive)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ class PerformanceAndroidEventProcessorTest {
setStoppedAt(100)
}
val startMs = metrics.appStartTimeSpan.startTimestampMs
// extended end is 500ms after start, well past the ~99ms natural duration
extendAppStartFinishedWith(SpanStatus.OK, startMs + 500)

var tr = createUiLoadTransactionWithAppStartChildSpan()
Expand All @@ -236,7 +235,6 @@ class PerformanceAndroidEventProcessorTest {
setStoppedAt(1000)
}
val startMs = metrics.appStartTimeSpan.startTimestampMs
// finished early (100ms), before the 999ms natural first-frame duration
extendAppStartFinishedWith(SpanStatus.OK, startMs + 100)

var tr = createUiLoadTransactionWithAppStartChildSpan()
Expand Down
Loading