refactor(extend-app-start): Rename AppStartExtension.finishAppStart to finishExtendedAppStart

buenaflor · claude · buenaflor · commit 01b1dc44fe5b · 2026-06-25T14:28:08.000+02:00
Implements the renamed IAppStartExtender.finishExtendedAppStart().

Co-Authored-By: Claude Opus 4.8 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/sentry-android-core/api/sentry-android-core.api b/sentry-android-core/api/sentry-android-core.api
@@ -188,7 +188,7 @@ public final class io/sentry/android/core/AppStartExtension : io/sentry/IAppStar
 	public fun <init> (Lio/sentry/android/core/performance/AppStartMetrics;)V
 	public fun clear ()V
 	public fun extendAppStart ()V
-	public fun finishAppStart ()V
+	public fun finishExtendedAppStart ()V
 	public fun finishTransaction (Lio/sentry/SentryDate;)V
 	public fun getExtendedAppStartSpan ()Lio/sentry/ISpan;
 	public fun getExtendedEndTime ()Lio/sentry/SentryDate;
diff --git a/sentry-android-core/src/main/java/io/sentry/android/core/AppStartExtension.java b/sentry-android-core/src/main/java/io/sentry/android/core/AppStartExtension.java
@@ -83,7 +83,7 @@ public void extendAppStart() {
   }
 
   @Override
-  public void finishAppStart() {
+  public void finishExtendedAppStart() {
     try (final @NotNull ISentryLifecycleToken ignored = lock.acquire()) {
       final @Nullable ISpan span = extendedSpan;
       if (span != null && !span.isFinished()) {
diff --git a/sentry-android-core/src/test/java/io/sentry/android/core/AppStartExtensionTest.kt b/sentry-android-core/src/test/java/io/sentry/android/core/AppStartExtensionTest.kt
@@ -104,29 +104,29 @@ class AppStartExtensionTest {
   }
 
   @Test
-  fun `finishAppStart without a prior extend is a no-op`() {
+  fun `finishExtendedAppStart without a prior extend is a no-op`() {
     val ext = extension()
-    ext.finishAppStart()
+    ext.finishExtendedAppStart()
     assertNull(ext.extendedEndTime)
   }
 
   @Test
-  fun `finishAppStart finishes the extended span`() {
+  fun `finishExtendedAppStart finishes the extended span`() {
     val ext = extension(windowOpen = true)
     val (_, span) = ext.registerHandOver()
     ext.extendAppStart()
-    ext.finishAppStart()
+    ext.finishExtendedAppStart()
     verify(span).finish(SpanStatus.OK)
   }
 
   @Test
-  fun `finishAppStart does not finish an already finished span`() {
+  fun `finishExtendedAppStart does not finish an already finished span`() {
     val ext = extension(windowOpen = true)
     val span = mock<ISpan>()
     whenever(span.isFinished).thenReturn(true)
     ext.registerHandOver(span = span)
     ext.extendAppStart()
-    ext.finishAppStart()
+    ext.finishExtendedAppStart()
     verify(span, never()).finish(any<SpanStatus>())
   }
 

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ public void extendAppStart() {`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`@Override`
`86`		`- public void finishAppStart() {`
	`86`	`+ public void finishExtendedAppStart() {`
`87`	`87`	`try (final @NotNull ISentryLifecycleToken ignored = lock.acquire()) {`
`88`	`88`	`final @Nullable ISpan span = extendedSpan;`
`89`	`89`	`if (span != null && !span.isFinished()) {`