libgit2: Enable tests#744
Merged
Merged
Conversation
darkowlzz
added
area/git
TestMain() without m.Run() resulted in none of the tests being run. This libgit2 package contains tests for both managed and unmanaged transports, enabling it in TestMain() for everything results in the unmanaged transport tests to not run. Add managed transport initialization call to all the managed transport tests to allow unmanaged transport tests to run. Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
force-pushed
the
libgit2-enable-tests
branch
from
75d7585 to
8661066
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestMain()withoutm.Run()resulted in none of the tests being run.This libgit2 package contains tests for both managed and unmanaged
transports, enabling it in TestMain() for everything results in the
unmanaged transport tests to not run. Add managed transport
initialization call to all the managed transport tests to allow
unmanaged transport tests to run.
Refer: https://github.com/fluxcd/source-controller/pull/727/files#r884158741