Update Fleet-maintained apps#48675
Conversation
Generated automatically with cmd/maintained-apps.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
WalkthroughThis PR bumps version metadata across 32 Fleet-maintained app manifest JSON files (macOS and Windows) in ChangesManifest version bumps (macOS): Actual, AltTab, Brave Browser, Claude, Dialpad, GoLand, Granola, Huly, JetBrains Toolbox, Kiro CLI, LookAway, Marked, Microsoft Edge, PhpStorm, Rocket.Chat, Super Productivity, WebStorm, Wispr Flow, Zen Browser, Beeper. Manifest version bumps (Windows): Arc, AWS CLI, Brave Browser, Claude, Egnyte, Granola, JetBrains Toolbox, Microsoft Edge, Rancher, Rider, Tower. Installer URL host change: 7-Zip Windows. Sequence Diagram(s)No sequence diagram generated; changes are flat data updates to JSON manifests without observable behavioral flow. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ee/maintained-apps/outputs/brave-browser/windows.json`:
- Around line 4-9: The Brave output is emitting an incorrect version string, and
both the version field and the version_compare threshold in the patched query
need to match the actual Brave release version. Update the generated Brave
browser metadata in the windows output, using the same corrected version value
that should also be applied in the matching darwin output, and ensure the
installer URL/release tag remain aligned with that release version. Focus on the
Brave browser output generator or transform that populates the version and
patched query values so the emitted metadata is consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 83a7a1a2-082e-455a-a4e9-e426bcfb87fa
📒 Files selected for processing (32)
ee/maintained-apps/outputs/7-zip/windows.jsonee/maintained-apps/outputs/actual/darwin.jsonee/maintained-apps/outputs/alt-tab/darwin.jsonee/maintained-apps/outputs/arc/windows.jsonee/maintained-apps/outputs/aws-cli/windows.jsonee/maintained-apps/outputs/beeper/darwin.jsonee/maintained-apps/outputs/brave-browser/darwin.jsonee/maintained-apps/outputs/brave-browser/windows.jsonee/maintained-apps/outputs/claude/darwin.jsonee/maintained-apps/outputs/claude/windows.jsonee/maintained-apps/outputs/dialpad/darwin.jsonee/maintained-apps/outputs/egnyte/windows.jsonee/maintained-apps/outputs/goland/darwin.jsonee/maintained-apps/outputs/granola/darwin.jsonee/maintained-apps/outputs/granola/windows.jsonee/maintained-apps/outputs/huly/darwin.jsonee/maintained-apps/outputs/jetbrains-toolbox/darwin.jsonee/maintained-apps/outputs/jetbrains-toolbox/windows.jsonee/maintained-apps/outputs/kiro-cli/darwin.jsonee/maintained-apps/outputs/lookaway/darwin.jsonee/maintained-apps/outputs/marked-app/darwin.jsonee/maintained-apps/outputs/microsoft-edge/darwin.jsonee/maintained-apps/outputs/microsoft-edge/windows.jsonee/maintained-apps/outputs/phpstorm/darwin.jsonee/maintained-apps/outputs/rancher/windows.jsonee/maintained-apps/outputs/rider/windows.jsonee/maintained-apps/outputs/rocket-chat/darwin.jsonee/maintained-apps/outputs/super-productivity/darwin.jsonee/maintained-apps/outputs/tower/windows.jsonee/maintained-apps/outputs/webstorm/darwin.jsonee/maintained-apps/outputs/wispr-flow/darwin.jsonee/maintained-apps/outputs/zen/darwin.json
| "version": "150.1.92.134", | ||
| "queries": { | ||
| "exists": "SELECT 1 FROM programs WHERE name = 'Brave' AND publisher = 'Brave Software Inc';", | ||
| "patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM programs WHERE name = 'Brave' AND publisher = 'Brave Software Inc' AND version_compare(version, '149.1.91.180') < 0);" | ||
| "patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM programs WHERE name = 'Brave' AND publisher = 'Brave Software Inc' AND version_compare(version, '150.1.92.134') < 0);" | ||
| }, | ||
| "installer_url": "https://github.com/brave/brave-browser/releases/download/v1.91.180/BraveBrowserStandaloneSilentSetup.exe", | ||
| "installer_url": "https://github.com/brave/brave-browser/releases/download/v1.92.134/BraveBrowserStandaloneSilentSetup.exe", |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== Files of interest ==\n'
git ls-files 'ee/maintained-apps/outputs/brave-browser/windows.json' \
'cmd/maintained-apps/*' \
'cmd/**/brave*' \
'ee/**/brave*' | sed 's#^`#-` #'
printf '\n== Brave output file (context) ==\n'
cat -n ee/maintained-apps/outputs/brave-browser/windows.json | sed -n '1,80p'
printf '\n== Search for Brave version parsing / maintained-apps generation ==\n'
rg -n --hidden --glob '!**/node_modules/**' --glob '!**/dist/**' --glob '!**/build/**' \
'brave|version_compare|DisplayVersion|maintained-apps|chromium' cmd ee .github . 2>/dev/null | sed -n '1,220p'Repository: fleetdm/fleet
Length of output: 50369
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== Brave transformer ==\n'
cat -n ee/maintained-apps/ingesters/homebrew/external_refs/brave_version_transformer.go | sed -n '1,220p'
printf '\n== Brave homebrew input ==\n'
cat -n ee/maintained-apps/inputs/homebrew/brave-browser.json | sed -n '1,220p'
printf '\n== Brave winget input ==\n'
cat -n ee/maintained-apps/inputs/winget/brave-browser.json | sed -n '1,220p'
printf '\n== Brave transformer test ==\n'
cat -n ee/maintained-apps/ingesters/homebrew/external_refs/brave_version_transformer_test.go | sed -n '1,260p'
printf '\n== Search for brave_version_transformer references ==\n'
rg -n 'brave_version_transformer|Brave|brave-browser' ee/maintained-apps cmd/maintained-apps server docs .github --glob '!**/node_modules/**' | sed -n '1,220p'Repository: fleetdm/fleet
Length of output: 38417
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== Brave transformer ==\n'
cat -n ee/maintained-apps/ingesters/homebrew/external_refs/brave_version_transformer.go | sed -n '1,220p'
printf '\n== Brave transformer test ==\n'
cat -n ee/maintained-apps/ingesters/homebrew/external_refs/brave_version_transformer_test.go | sed -n '1,260p'
printf '\n== Brave input files ==\n'
cat -n ee/maintained-apps/inputs/homebrew/brave-browser.json | sed -n '1,220p'
printf '\n---\n'
cat -n ee/maintained-apps/inputs/winget/brave-browser.json | sed -n '1,220p'
printf '\n== Narrow search for version shaping ==\n'
rg -n '150\.1\.92\.134|1\.92\.134|Chromium 150|brave_version_transformer|version_transform' \
ee/maintained-apps cmd/maintained-apps server docs .github --glob '!**/node_modules/**' | sed -n '1,220p'Repository: fleetdm/fleet
Length of output: 5909
🌐 Web query:
Brave Browser Windows installer DisplayVersion 150.1.92.134 versioning release notes Chromium 150.1.92.134
💡 Result:
The Brave Browser version you referenced appears to be a conflation of Brave's release numbering and the underlying Chromium version. Based on official development records as of July 3, 2026, there is no Brave release version 150.1.92.134. The release branch 1.92.x (e.g., v1.92.131) is based on Chromium 150.0.7871.46 [1], which was recently updated to Chromium 150.0.7871.63 [2]. The number 150.1.92.134 you provided likely mistakenly combines components from these two sources (Chromium 150.x and Brave 1.92.x) [2][1]. Key details regarding the current Brave 1.92.x release cycle: - Release Channel: Brave version 1.92.x series [2]. - Chromium Version: Upgraded from 150.0.7871.46 to 150.0.7871.63 [2]. - Notable Changes: Improvements to vertical tabs, auto-replacement of certain Web Store MV2 extensions with Brave-hosted equivalents, and various AI chat and UI/UX fixes [2]. For accurate versioning and release notes, always refer to the official Brave GitHub releases page or the Brave Release Notes page [3][4].
Citations:
- 1: https://newreleases.io/project/github/brave/brave-browser/release/v1.92.131
- 2: Desktop Release Notes for 1.92.x Release brave/brave-browser#56813
- 3: https://github.com/brave/brave-browser/releases
- 4: https://brave.com/latest/
Fix the Brave version string
version and version_compare are using 150.1.92.134, but the Brave release tag and installer URL are v1.92.134. The same bad value also appears in ee/maintained-apps/outputs/brave-browser/darwin.json, so this looks like an ingest/transform bug. Align the emitted version and patch threshold with the Brave release version.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ee/maintained-apps/outputs/brave-browser/windows.json` around lines 4 - 9,
The Brave output is emitting an incorrect version string, and both the version
field and the version_compare threshold in the patched query need to match the
actual Brave release version. Update the generated Brave browser metadata in the
windows output, using the same corrected version value that should also be
applied in the matching darwin output, and ensure the installer URL/release tag
remain aligned with that release version. Focus on the Brave browser output
generator or transform that populates the version and patched query values so
the emitted metadata is consistent.
|
Closing in favor of #48676. |
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit