Issue #168 wrap xcodebuild calls within ruby system environment#176
Conversation
There was a problem hiding this comment.
Any reason why we don't just run it directly from there?
There was a problem hiding this comment.
I originally meant it like that because of:
- cleaner command line
- easy to access the script to modify it and adapt it while developing
- similar to the way we install other wrapper scripts.
But I can see that this can cause problems with upgrades as is (it your newer version of gym contains an improved wrapper, it won't be copied over).
So I'll make it run in place instead. I'll fix it later today.
|
Thanks for testing this. We'd need to test it on a System Ruby installation as well before we can merge it 👍 |
lacostej
force-pushed
the
features/wrap_xcodebuild
branch
from
88a2b7c to
1160c19
Compare
|
My little gist done all growd up! |
|
Thanks @lacostej for preparing this. As this is taken from https://gist.github.com/claybridges/cea5d4afd24eda268164 via @claybridges we'd also need to be sure the license is okay. @claybridges do you give permission to merge this in under the MIT license of fastlane? |
|
@lacostej There seems to be a merge conflict 😢 |
lacostej
force-pushed
the
features/wrap_xcodebuild
branch
from
47c80c2 to
41dcf91
Compare
|
WRT the gist license, @claybridges's gist went from 5 lines including shebang and enabling debugging to 14, so I hope it's not that of a blocker :) While I am at it, there are probably other ways to implement this, like in pure ruby: https://github.com/pitluga/subcontractor/blob/master/lib/subcontractor/cli.rb#L9-L33 |
|
Hi guys. I release this tiny script into the public domain with no copyright attachments whatsoever. Happy it's seeing some use. |
|
Merci @claybridges ! |
Issue #168 wrap xcodebuild calls within ruby system environment
|
Perfect, thanks @claybridges and @lacostej 🚀 |
3 participants
This pull request aims to provide a safe wrapper.
The xcbuild-wrapper.sh originates from a gist linked from a stackoverflow, and was modified to make sure it works when:
I suspect this is good enough and I don't need to use sudo to test the same thing.