BUG: Safe hasattr for PyQt5#1161
Merged
Merged
Conversation
Contributor
|
Thanks - this looks like a reasonable fix. |
Contributor
Author
|
There was a timeout on one run after 360 minutes (!) that's hopefully unrelated, so rather than pushing an empty commit (to get CIs to run again) I added a |
Contributor
|
Yes, it is almost certainly orthogonal - I haven't seen that sort of error in the CI runs, but I will keep an eye out for it in the future. I think this should be good to merge. |
corranwebster
approved these changes
Oct 12, 2022
corranwebster
added
the
needs backport to maint/*
corranwebster
added a commit
that referenced
this pull request
Nov 11, 2022
* BUG: Safe hasattr for PyQt5 * Update pyface/ui/qt4/action/action_item.py * MAINT: Timeout Co-authored-by: Corran Webster <cwebster@enthought.com>
corranwebster
added a commit
that referenced
this pull request
Nov 14, 2022
* BUG: Safe hasattr for PyQt5 * Update pyface/ui/qt4/action/action_item.py * MAINT: Timeout Co-authored-by: Corran Webster <cwebster@enthought.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over in enthought/mayavi#1180 I am working on VTK 9.2.2 fixes, and I am getting a segfault in CIs during GC:
https://github.com/enthought/mayavi/actions/runs/3222141217/jobs/5270891488
Locally I don't get a segfault but rather a slightly nicer error message:
This PR fixes this by catching this
RuntimeErrorduringhasattr. Locally at least the Mayavi tests pass with PyQt5 with this change.