MAINT: Support Python 3.9#983
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
=======================================
Coverage 49.79% 49.79%
=======================================
Files 263 263
Lines 23927 23927
Branches 3259 3259
=======================================
Hits 11914 11914
Misses 11236 11236
Partials 777 777
Continue to review full report at Codecov.
|
rahulporuri
reviewed
Dec 10, 2020
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
I think we can simply remove the temporary variables now and just use base64.decodebytes or base64.encodebytes. Can you please make that change?
Collaborator
Author
|
@rahulporuri done |
rahulporuri
approved these changes
Dec 10, 2020
Member
|
@larsoner -- thanks! @rahulporuri -- thanks for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
base64.decodestringdoes not exist in Python 3.9 so currentmastercauses an error on import.decodestringhas been deprecated since 3.1 so should be safe just to usedecodebytesdirectly (and same withencodebytes).