Skip to content

⬆️ imp to importlib #892#893

Merged
prabhuramachandran merged 4 commits into
enthought:masterfrom
tkoyama010:tkoyama010-patch-2
Apr 30, 2020
Merged

⬆️ imp to importlib #892#893
prabhuramachandran merged 4 commits into
enthought:masterfrom
tkoyama010:tkoyama010-patch-2

Conversation

@tkoyama010
Copy link
Copy Markdown
Contributor

@tkoyama010 tkoyama010 commented Feb 10, 2020

⬆️ imp to importlib #892

@tkoyama010
Copy link
Copy Markdown
Contributor Author

tkoyama010 commented Feb 10, 2020

Can anybody solve this error? It seems the CI problem.
https://travis-ci.org/enthought/mayavi/jobs/648265707#L52

@mdickinson
Copy link
Copy Markdown
Member

mdickinson commented Feb 10, 2020

@tkoyama010 That error seems to be case of #861. I've restarted the failing Travis job to see if we can get it to pass.

mdickinson
mdickinson reviewed Feb 10, 2020
View reviewed changes
Comment thread mayavi/core/base.py
mdickinson
mdickinson requested changes Feb 10, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to fix the places where imp is used to use importlib instead. Ideally, we should also have a test that exercises that code.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 10, 2020 •
edited
Loading

Codecov Report

Merging #893 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
- Coverage   50.87%   50.86%   -0.01%     
==========================================
  Files         263      263              
  Lines       23843    23843              
  Branches     3251     3251              
==========================================
- Hits        12130    12128       -2     
- Misses      10927    10928       +1     
- Partials      786      787       +1
Impacted Files Coverage Δ
mayavi/core/base.py 57.27% <50%> (ø) ⬆️
tvtk/tvtk_base.py 78.96% <0%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 749199d...0007113. Read the comment docs.

@tkoyama010
Copy link
Copy Markdown
Contributor Author

tkoyama010 commented Feb 10, 2020

I also fixed the test source code 🆙

@tkoyama010
Copy link
Copy Markdown
Contributor Author

tkoyama010 commented Feb 10, 2020 •
edited
Loading

Oops. It fails only in Python 2.7 😢 Should I revert 7998d70
or ignore the error of Python2.7(which is EOF)? #845
https://travis-ci.org/enthought/mayavi/jobs/648342402#L629

@tkoyama010 tkoyama010 mentioned this pull request Feb 10, 2020
Closed
@tkoyama010
Copy link
Copy Markdown
Contributor Author

tkoyama010 commented Feb 10, 2020

I move importlib to reload_module in six 😄

@prabhuramachandran
Copy link
Copy Markdown
Member

prabhuramachandran commented Apr 25, 2020

@mdickinson -- is this OK to merge? You have a review and I do not want to dismiss it. Thanks.

@mdickinson
Copy link
Copy Markdown
Member

mdickinson commented Apr 27, 2020

@prabhuramachandran Sure. I still think there should be a test that exercises the code, but that's up to you. :-)

prabhuramachandran added a commit to prabhuramachandran/mayavi that referenced this pull request Apr 30, 2020
@prabhuramachandran
Add tests to test if hand-crafted views work.
b3cde91 
This should address the lack of tests in enthought#893.  Also cleaned up the base
module a little in the process.
@prabhuramachandran prabhuramachandran mentioned this pull request Apr 30, 2020
Merged
@prabhuramachandran
Copy link
Copy Markdown
Member

prabhuramachandran commented Apr 30, 2020

Merging this now, I am addressing some tests (not the greatest test but it is something) in #913.

@prabhuramachandran prabhuramachandran merged commit 9c9a6a1 into enthought:master Apr 30, 2020
@prabhuramachandran prabhuramachandran mentioned this pull request Apr 30, 2020
Closed
prabhuramachandran added a commit to prabhuramachandran/mayavi that referenced this pull request Apr 30, 2020
@prabhuramachandran
Add tests to test if hand-crafted views work.
f06c7cc 
This should address the lack of tests in enthought#893.  Also cleaned up the base
module a little in the process.
@tkoyama010
Copy link
Copy Markdown
Contributor Author

tkoyama010 commented May 5, 2020

Thanks.

@tkoyama010 tkoyama010 deleted the tkoyama010-patch-2 branch May 5, 2020 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tkoyama010 @mdickinson @codecov-io @prabhuramachandran