Skip to content

Misc bug fixes#800

Merged
prabhuramachandran merged 3 commits into
enthought:masterfrom
prabhuramachandran:misc-bugs
Jul 4, 2019
Merged

Misc bug fixes#800
prabhuramachandran merged 3 commits into
enthought:masterfrom
prabhuramachandran:misc-bugs

Conversation

@prabhuramachandran
Copy link
Copy Markdown
Member

Fixes 3 issues that affect the new release due to changes in traits, pyface etc.

  • Fix issue with CTF editor not showing.
  • Fix issue with lut editor not launching.
  • Fix issue with cut/pasting tree nodes and drag drop onto shell.

This looks like a silly error from a previous commit and made the CTF
editor useless.
Now we also use the Qt version if the Qt backend is in use.
Recent changes to the tree editor seems to have added a listener_cache
attribute which is not properly picklable and there is no need to pickle
it.  This was preventing drag/drop from the nodes to the Python shell
and also any cut/paste action from working.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 4, 2019

Codecov Report

Merging #800 into master will decrease coverage by <.01%.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #800      +/-   ##
==========================================
- Coverage   50.86%   50.86%   -0.01%     
==========================================
  Files         263      263              
  Lines       23845    23848       +3     
  Branches     3252     3252              
==========================================
+ Hits        12129    12130       +1     
- Misses      10929    10931       +2     
  Partials      787      787
Impacted Files Coverage Δ
mayavi/core/base.py 57.27% <ø> (ø) ⬆️
tvtk/util/gradient_editor.py 18.86% <0%> (-0.05%) ⬇️
tvtk/util/wx_gradient_editor.py 0% <0%> (ø) ⬆️
tvtk/util/qt_gradient_editor.py 0% <0%> (ø) ⬆️
mayavi/core/lut_manager.py 56.53% <50%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a7529...ff17689. Read the comment docs.

@prabhuramachandran prabhuramachandran merged commit b082bdb into enthought:master Jul 4, 2019
@prabhuramachandran prabhuramachandran deleted the misc-bugs branch July 4, 2019 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants